Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 892893005: Remove unused "sync_promo.error_message" preference (Closed)

Created:
5 years, 10 months ago by qi1988.yang
Modified:
5 years, 10 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused "sync_promo.error_message" preference Remove the cleanup of 'sync_promo.error_message' preference in browser_prefs::MigrateUserPrefs. BUG=268442 Committed: https://crrev.com/cffb6b3d3aa6aaf42978b1a0b91c3d03f2feeeb2 Cr-Commit-Position: refs/heads/master@{#315960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M chrome/browser/prefs/browser_prefs.cc View 3 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
qi1988.yang
PTAL! Thanks!
5 years, 10 months ago (2015-02-12 06:42:34 UTC) #2
Bernhard Bauer
lgtm
5 years, 10 months ago (2015-02-12 09:28:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892893005/1
5 years, 10 months ago (2015-02-12 10:18:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 11:31:18 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 11:31:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cffb6b3d3aa6aaf42978b1a0b91c3d03f2feeeb2
Cr-Commit-Position: refs/heads/master@{#315960}

Powered by Google App Engine
This is Rietveld 408576698