Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 892853002: MIPS64: Fix bugs after hole-nan value change. (Closed)

Created:
5 years, 10 months ago by paul.l...
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix bugs after hole-nan value change. TEST=mjsunit/regress/regress-undefined-nan{2,3}, mjsunit/elements-transition, mjsunit/elide-double-hole-check-* BUG= Committed: https://crrev.com/1ea1141c81caf3f33d72f2f7f07c6d1719ef7d51 Cr-Commit-Position: refs/heads/master@{#26374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M src/mips64/lithium-codegen-mips64.cc View 6 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
paul.l...
PTAL, this resolves all the issues on the sim builds.
5 years, 10 months ago (2015-02-01 21:57:06 UTC) #2
akos.palfi.imgtec
LGTM.
5 years, 10 months ago (2015-02-01 23:35:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892853002/1
5 years, 10 months ago (2015-02-01 23:37:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 00:00:09 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 00:00:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ea1141c81caf3f33d72f2f7f07c6d1719ef7d51
Cr-Commit-Position: refs/heads/master@{#26374}

Powered by Google App Engine
This is Rietveld 408576698