Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2812)

Unified Diff: src/deoptimizer.h

Issue 892843007: Revert of Externalize deoptimization reasons. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/deoptimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/deoptimizer.h
diff --git a/src/deoptimizer.h b/src/deoptimizer.h
index 7245810f21ceb0db0f44e1b36fd1699cc6444d65..47412f47526e4e6ec803322bfccab96c9bb2218a 100644
--- a/src/deoptimizer.h
+++ b/src/deoptimizer.h
@@ -85,83 +85,6 @@
// from given native context.
virtual void LeaveContext(Context* context) = 0;
};
-
-
-#define DEOPT_MESSAGES_LIST(V) \
- V(kNoReason, "no reason") \
- V(kConstantGlobalVariableAssignment, "Constant global variable assignment") \
- V(kConversionOverflow, "conversion overflow") \
- V(kDivisionByZero, "division by zero") \
- V(kElementsKindUnhandledInKeyedLoadGenericStub, \
- "ElementsKind unhandled in KeyedLoadGenericStub") \
- V(kExpectedHeapNumber, "Expected heap number") \
- V(kExpectedSmi, "Expected smi") \
- V(kForcedDeoptToRuntime, "Forced deopt to runtime") \
- V(kHole, "hole") \
- V(kHoleyArrayDespitePackedElements_kindFeedback, \
- "Holey array despite packed elements_kind feedback") \
- V(kInstanceMigrationFailed, "instance migration failed") \
- V(kInsufficientTypeFeedbackForCallWithArguments, \
- "Insufficient type feedback for call with arguments") \
- V(kInsufficientTypeFeedbackForCombinedTypeOfBinaryOperation, \
- "Insufficient type feedback for combined type of binary operation") \
- V(kInsufficientTypeFeedbackForGenericNamedAccess, \
- "Insufficient type feedback for generic named access") \
- V(kInsufficientTypeFeedbackForKeyedLoad, \
- "Insufficient type feedback for keyed load") \
- V(kInsufficientTypeFeedbackForKeyedStore, \
- "Insufficient type feedback for keyed store") \
- V(kInsufficientTypeFeedbackForLHSOfBinaryOperation, \
- "Insufficient type feedback for LHS of binary operation") \
- V(kInsufficientTypeFeedbackForRHSOfBinaryOperation, \
- "Insufficient type feedback for RHS of binary operation") \
- V(kKeyIsNegative, "key is negative") \
- V(kLostPrecision, "lost precision") \
- V(kLostPrecisionOrNaN, "lost precision or NaN") \
- V(kMementoFound, "memento found") \
- V(kMinusZero, "minus zero") \
- V(kNaN, "NaN") \
- V(kNegativeKeyEncountered, "Negative key encountered") \
- V(kNegativeValue, "negative value") \
- V(kNoCache, "no cache") \
- V(kNonStrictElementsInKeyedLoadGenericStub, \
- "non-strict elements in KeyedLoadGenericStub") \
- V(kNotADateObject, "not a date object") \
- V(kNotAHeapNumber, "not a heap number") \
- V(kNotAHeapNumberUndefinedBoolean, "not a heap number/undefined/true/false") \
- V(kNotAHeapNumberUndefined, "not a heap number/undefined") \
- V(kNotAJavaScriptObject, "not a JavaScript object") \
- V(kNotASmi, "not a Smi") \
- V(kNotHeapNumber, "not heap number") \
- V(kNull, "null") \
- V(kOutOfBounds, "out of bounds") \
- V(kOutsideOfRange, "Outside of range") \
- V(kOverflow, "overflow") \
- V(kReceiverWasAGlobalObject, "receiver was a global object") \
- V(kSmi, "Smi") \
- V(kTooManyArguments, "too many arguments") \
- V(kTooManyUndetectableTypes, "Too many undetectable types") \
- V(kTracingElementsTransitions, "Tracing elements transitions") \
- V(kTypeMismatchBetweenFeedbackAndConstant, \
- "Type mismatch between feedback and constant") \
- V(kUndefined, "undefined") \
- V(kUnexpectedCellContentsInConstantGlobalStore, \
- "Unexpected cell contents in constant global store") \
- V(kUnexpectedCellContentsInGlobalStore, \
- "Unexpected cell contents in global store") \
- V(kUnexpectedObject, "unexpected object") \
- V(kUnexpectedRHSOfBinaryOperation, "Unexpected RHS of binary operation") \
- V(kUninitializedBoilerplateInFastClone, \
- "Uninitialized boilerplate in fast clone") \
- V(kUninitializedBoilerplateLiterals, "Uninitialized boilerplate literals") \
- V(kUnknownMapInPolymorphicAccess, "Unknown map in polymorphic access") \
- V(kUnknownMapInPolymorphicCall, "Unknown map in polymorphic call") \
- V(kUnknownMapInPolymorphicElementAccess, \
- "Unknown map in polymorphic element access") \
- V(kUnknownMap, "Unknown map") \
- V(kValueMismatch, "value mismatch") \
- V(kWrongInstanceType, "wrong instance type") \
- V(kWrongMap, "wrong map")
class Deoptimizer : public Malloced {
@@ -176,29 +99,21 @@
kBailoutTypesWithCodeEntry = SOFT + 1
};
-#define DEOPT_MESSAGES_CONSTANTS(C, T) C,
- enum DeoptReason {
- DEOPT_MESSAGES_LIST(DEOPT_MESSAGES_CONSTANTS) kLastDeoptReason
- };
-#undef DEOPT_MESSAGES_CONSTANTS
-
- static const char* GetDeoptReason(DeoptReason deopt_reason);
-
struct Reason {
- Reason(int r, const char* m, DeoptReason d)
- : raw_position(r), mnemonic(m), deopt_reason(d) {}
+ Reason(int r, const char* m, const char* d)
+ : raw_position(r), mnemonic(m), detail(d) {}
bool operator==(const Reason& other) const {
return raw_position == other.raw_position &&
CStringEquals(mnemonic, other.mnemonic) &&
- deopt_reason == other.deopt_reason;
+ CStringEquals(detail, other.detail);
}
bool operator!=(const Reason& other) const { return !(*this == other); }
int raw_position;
const char* mnemonic;
- DeoptReason deopt_reason;
+ const char* detail;
};
struct JumpTableEntry : public ZoneObject {
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/deoptimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698