Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 892843007: Revert of Externalize deoptimization reasons. (Closed)

Created:
5 years, 10 months ago by loislo
Modified:
5 years, 10 months ago
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Externalize deoptimization reasons. (patchset #6 id:100001 of https://codereview.chromium.org/874323003/) Reason for revert: it broke the build Original issue's description: > Externalize deoptimization reasons. > > 1) The hardcoded strings were converted into DeoptReason enum. > > 2) Deopt comment were converted into a pair location and deopt reason entries so > the deopt reason tracking mode would less affect the size of the RelocInfo table and heap. > > 3) DeoptReason entry in RelocInfo reuses kCommentTag value and generates short entry in RelocInfo table. > > BUG=452067 > LOG=n > > Committed: https://crrev.com/c49820e45b57f128a98690940875c049f612dde6 > Cr-Commit-Position: refs/heads/master@{#26434} TBR=alph@chromium.org,mstarzinger@chromium.org,svenpanne@chromium.org,yurys@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=452067 Committed: https://crrev.com/bfc5d83bd0b8ca5db26478d4ad78dcdacb6fe980 Cr-Commit-Position: refs/heads/master@{#26435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+923 lines, -1238 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 76 chunks +98 lines, -98 lines 0 comments Download
M src/arm64/assembler-arm64.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.h View 1 chunk +13 lines, -20 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 71 chunks +121 lines, -134 lines 0 comments Download
M src/assembler.h View 4 chunks +6 lines, -8 lines 0 comments Download
M src/assembler.cc View 8 chunks +2 lines, -24 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 11 chunks +11 lines, -14 lines 0 comments Download
M src/deoptimizer.h View 2 chunks +4 lines, -89 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/disassembler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/hydrogen.h View 4 chunks +8 lines, -8 lines 0 comments Download
M src/hydrogen.cc View 22 chunks +30 lines, -38 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 75 chunks +103 lines, -105 lines 0 comments Download
M src/lithium-codegen.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/mips/assembler-mips.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 chunk +4 lines, -6 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 73 chunks +101 lines, -138 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 72 chunks +101 lines, -140 lines 0 comments Download
M src/objects.cc View 2 chunks +7 lines, -12 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 83 chunks +97 lines, -99 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 77 chunks +104 lines, -106 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 72 chunks +98 lines, -100 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
loislo
Created Revert of Externalize deoptimization reasons.
5 years, 10 months ago (2015-02-04 16:47:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892843007/1
5 years, 10 months ago (2015-02-04 16:48:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 16:48:28 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 16:48:44 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfc5d83bd0b8ca5db26478d4ad78dcdacb6fe980
Cr-Commit-Position: refs/heads/master@{#26435}

Powered by Google App Engine
This is Rietveld 408576698