Source/core/rendering/svg/RenderSVGResourceFilterPrimitive.h - Issue 89283002: Merge two determineFilterPrimitiveSubregion implementations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGResourceFilterPrimitive.h

Issue 89283002: Merge two determineFilterPrimitiveSubregion implementations (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix final nit Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/rendering/svg/RenderSVGResourceFilter.cpp ('k') | Source/core/rendering/svg/RenderSVGResourceFilterPrimitive.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/svg/RenderSVGResourceFilterPrimitive.h

diff --git a/Source/core/rendering/svg/RenderSVGResourceFilterPrimitive.h b/Source/core/rendering/svg/RenderSVGResourceFilterPrimitive.h

index e2edf3f852d08363859833e2d202a691589e0c9c..704df3d4075ae951e453a1e15ef9a780ff0eac2d 100644

--- a/Source/core/rendering/svg/RenderSVGResourceFilterPrimitive.h

+++ b/Source/core/rendering/svg/RenderSVGResourceFilterPrimitive.h

@@ -31,8 +31,6 @@

namespace WebCore {

-class FilterEffect;

class RenderSVGResourceFilterPrimitive FINAL : public RenderSVGHiddenContainer {

public:

explicit RenderSVGResourceFilterPrimitive(SVGElement* filterPrimitiveElement)

@@ -45,9 +43,6 @@ public:

virtual const char* renderName() const { return "RenderSVGResourceFilterPrimitive"; }

virtual bool isSVGResourceFilterPrimitive() const { return true; }

- // They depend on the RenderObject argument of RenderSVGResourceFilter::applyResource.

- static FloatRect determineFilterPrimitiveSubregion(FilterEffect*);

inline void primitiveAttributeChanged(const QualifiedName& attribute)

{

RenderObject* filter = parent();