Source/core/rendering/FilterEffectRenderer.cpp - Issue 89283002: Merge two determineFilterPrimitiveSubregion implementations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/FilterEffectRenderer.cpp

Issue 89283002: Merge two determineFilterPrimitiveSubregion implementations (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix final nit Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/platform/graphics/filters/FilterEffect.cpp ('k') | Source/core/rendering/svg/RenderSVGResourceFilter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/FilterEffectRenderer.cpp

diff --git a/Source/core/rendering/FilterEffectRenderer.cpp b/Source/core/rendering/FilterEffectRenderer.cpp

index d8f0eef23435df11476173b74153883be21fde02..03556781265670816e053f4dd72b5f8b531f4995 100644

--- a/Source/core/rendering/FilterEffectRenderer.cpp

+++ b/Source/core/rendering/FilterEffectRenderer.cpp

@@ -373,7 +373,7 @@ bool FilterEffectRendererHelper::prepareFilterEffect(RenderLayer* renderLayer, c

filter->setAbsoluteTransform(absoluteTransform);

filter->setAbsoluteFilterRegion(AffineTransform().scale(zoom).mapRect(filterSourceRect));

filter->setFilterRegion(absoluteTransform.inverse().mapRect(filterSourceRect));

- filter->lastEffect()->determineFilterPrimitiveSubregion();

+ filter->lastEffect()->determineFilterPrimitiveSubregion(MapRectForward);

bool hasUpdatedBackingStore = filter->updateBackingStoreRect(filterSourceRect);

if (filter->hasFilterThatMovesPixels()) {

« no previous file with comments | « Source/core/platform/graphics/filters/FilterEffect.cpp ('k') | Source/core/rendering/svg/RenderSVGResourceFilter.cpp » ('j') | no next file with comments »