Merge two determineFilterPrimitiveSubregion implementations

Source/core/platform/graphics/filters/FilterEffect.h

 /*
  * Copyright (C) 2008 Alex Mathews <possessedpenguinbob@gmail.com>
  * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 137 matching lines @@
     void setClipsToBounds(bool value) { m_clipsToBounds = value; }
 
     ColorSpace operatingColorSpace() const { return m_operatingColorSpace; }
     virtual void setOperatingColorSpace(ColorSpace colorSpace) { m_operatingColorSpace = colorSpace; }
     ColorSpace resultColorSpace() const { return m_resultColorSpace; }
     virtual void setResultColorSpace(ColorSpace colorSpace) { m_resultColorSpace = colorSpace; }
 
     virtual void transformResultColorSpace(FilterEffect* in, const int) { in->transformResultColorSpace(m_operatingColorSpace); }
     void transformResultColorSpace(ColorSpace);
 
-    FloatRect determineFilterPrimitiveSubregion();
+    FloatRect determineFilterPrimitiveSubregion(bool mapRectForward = true, bool clipToFilterRegion = false);

[Stephen White, 2013/11/26 22:11:14]

Per http://www.chromium.org/blink/coding-style#TOC-Right:25

rather than two bools, I think it would be clearer if this was a single "Flags"
enum, so the call sites are self-documenting, e.g.,

effect->determineFilterPrimitiveSubregion(MapRectForward | ClipToFilterRegion)

[rwlbuis, 2013/11/26 22:28:36]

Sounds great, fixing.

 
 protected:
     FilterEffect(Filter*);
 
     ImageBuffer* createImageBufferResult();
     Uint8ClampedArray* createUnmultipliedImageResult();
     Uint8ClampedArray* createPremultipliedImageResult();
 
     // Return true if the filter will only operate correctly on valid RGBA values, with
     // alpha in [0,255] and each color component in [0, alpha].
@@ skipping 41 matching lines @@
     // Should the effect clip to its primitive region, or expand to use the combined region of its inputs.
     bool m_clipsToBounds;
 
     ColorSpace m_operatingColorSpace;
     ColorSpace m_resultColorSpace;
 };
 
 } // namespace WebCore
 
 #endif // FilterEffect_h