cc/PRESUBMIT.py - Issue 892743002: cc: Simplify the presubmit regex used to identify paths and files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/PRESUBMIT.py

Issue 892743002: cc: Simplify the presubmit regex used to identify paths and files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add missing comma Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/PRESUBMIT.py

diff --git a/cc/PRESUBMIT.py b/cc/PRESUBMIT.py

index 71c4ea1f1f635c299524eea77c4787a3037ef4fe..ec73b0f8dbcb1e505c1beef53eb7758459c4a918 100644

--- a/cc/PRESUBMIT.py

+++ b/cc/PRESUBMIT.py

@@ -11,7 +11,7 @@ for more details about the presubmit API built into depot_tools.

import re

import string

-CC_SOURCE_FILES=(r'^cc/.*\.(cc|h)$', r'^cc\\.*\.(cc|h)$')

+CC_SOURCE_FILES=(r'^cc[\\\/].*\.(cc|h)$',)

tfarina 2015/01/31 00:55:10 CRAZY! Adding the comma at the end made it pass.

danakj 2015/01/31 00:58:22 Yes, it expects CC_SOURCE_FILES[0] to be a regex,

def CheckChangeLintsClean(input_api, output_api):

input_api.cpplint._cpplint_state.ResetErrorCounts() # reset global state

« no previous file with comments | « no previous file | no next file » | no next file with comments »