cc: Simplify the presubmit regex used to identify paths and files.

cc: Simplify the presubmit regex used to identify paths and files.

This [\\/] should account for both Windows \ and Posix /.

BUG=None
TEST=git cl presubmit -uv
R=danakj@chromium.org

Committed: https://crrev.com/26ef0f02d693f5106e4ef17748e61e8f68fb05a2
Cr-Commit-Position: refs/heads/master@{#314145}

[tfarina, 2015-01-31 00:24:55]

When I tried this:

Running presubmit upload checks ...
Running /home/tfarina/chromium/src/PRESUBMIT.py
Running /home/tfarina/chromium/src/cc/PRESUBMIT.py
Ignoring /home/tfarina/chromium/src/cc/PRESUBMIT.py; not a valid file name (cc,
h, cpp, cu, cuh)
Done processing /home/tfarina/chromium/src/cc/PRESUBMIT.py

** Presubmit ERRORS **
These files use ASSERT instead of using DCHECK:
  cc/PRESUBMIT.py

std::abs() should be used instead of std::fabs() for consistency.
  cc/PRESUBMIT.py

These files use abs(), absf(), fabs(), or fabsf() without qualifying the std
namespace. Please use std::abs() in all places.
  cc/PRESUBMIT.py

Use >> instead of > >:
  cc/PRESUBMIT.py

The old way seems to work though.

The [\\\/] means: "Match any character in the set" according to
http://www.regexr.com/. And it seems to be used in other presubmit scripts.

PTAL!

https://codereview.chromium.org/892743002/diff/1/cc/PRESUBMIT.py
File cc/PRESUBMIT.py (right):

https://codereview.chromium.org/892743002/diff/1/cc/PRESUBMIT.py#newcode14
cc/PRESUBMIT.py:14: CC_SOURCE_FILES=(r'^cc[\\\/].*\.(cc|h)$')
Not sure if it is something wrong with this new way or something else.

Maybe you guys are more familiar with Regex will spot it.

[danakj, 2015-01-31 00:45:35]

https://codereview.chromium.org/892743002/diff/1/cc/PRESUBMIT.py
File cc/PRESUBMIT.py (right):

https://codereview.chromium.org/892743002/diff/1/cc/PRESUBMIT.py#newcode14
cc/PRESUBMIT.py:14: CC_SOURCE_FILES=(r'^cc[\\\/].*\.(cc|h)$')
On 2015/01/31 00:24:55, tfarina wrote:
> Not sure if it is something wrong with this new way or something else.
> 
> Maybe you guys are more familiar with Regex will spot it.

From git history, this used to be

1d99317a7 (danakj@chromium.org        2012-10-18 18:15:04 +0000  14)
CC_SOURCE_FILES=(r'^cc/.*\.(cc|h)$',)

Note the , at the end.

[tfarina, 2015-01-31 00:55:11]

https://codereview.chromium.org/892743002/diff/20001/cc/PRESUBMIT.py
File cc/PRESUBMIT.py (right):

https://codereview.chromium.org/892743002/diff/20001/cc/PRESUBMIT.py#newcode14
cc/PRESUBMIT.py:14: CC_SOURCE_FILES=(r'^cc[\\\/].*\.(cc|h)$',)
CRAZY! Adding the comma at the end made it pass.

[danakj, 2015-01-31 00:58:23]

https://codereview.chromium.org/892743002/diff/20001/cc/PRESUBMIT.py
File cc/PRESUBMIT.py (right):

https://codereview.chromium.org/892743002/diff/20001/cc/PRESUBMIT.py#newcode14
cc/PRESUBMIT.py:14: CC_SOURCE_FILES=(r'^cc[\\\/].*\.(cc|h)$',)
On 2015/01/31 00:55:10, tfarina wrote:
> CRAZY! Adding the comma at the end made it pass. 

Yes, it expects CC_SOURCE_FILES[0] to be a regex, without the comma [0] is the
first character or something.

Why are there 3 /'s instead of 2?

[tfarina, 2015-01-31 01:17:06]

On 2015/01/31 00:58:23, danakj wrote:
> https://codereview.chromium.org/892743002/diff/20001/cc/PRESUBMIT.py
> File cc/PRESUBMIT.py (right):
> 
> https://codereview.chromium.org/892743002/diff/20001/cc/PRESUBMIT.py#newcode14
> cc/PRESUBMIT.py:14: CC_SOURCE_FILES=(r'^cc[\\\/].*\.(cc|h)$',)
> On 2015/01/31 00:55:10, tfarina wrote:
> > CRAZY! Adding the comma at the end made it pass. 
> 
> Yes, it expects CC_SOURCE_FILES[0] to be a regex, without the comma [0] is the
> first character or something.
> 
> Why are there 3 /'s instead of 2?

I'm not a regex expert, but according to http://www.regexr.com/, looking at the
"Escaped characters" section, it seems to be because it is like this:

\          \\          -> Matches a "\" character
/          \/          -> Matches a "/" character

And thus:

\\\/ should match either backslash (\) or slash (/).

[danakj, 2015-01-31 01:19:58]

But / matches a /. You only do \\ instead of \ because \ is escape so you need 2
to make a literal \.

[jbauman, 2015-01-31 01:28:59]

On 2015/01/31 01:19:58, danakj wrote:
> But / matches a /. You only do \\ instead of \ because \ is escape so you need
2
> to make a literal \.

\/ happens to work because the "\" is ignored because "/" isn't special (except
in perl sometimes), but it'd be clearer to use "[\\/]"

[tfarina, 2015-01-31 01:31:26]

On 2015/01/31 01:28:59, jbauman wrote:
> On 2015/01/31 01:19:58, danakj wrote:
> > But / matches a /. You only do \\ instead of \ because \ is escape so you
need
> 2
> > to make a literal \.
> 
> \/ happens to work because the "\" is ignored because "/" isn't special
(except
> in perl sometimes), but it'd be clearer to use "[\\/]"

Yup. You are right, it is true. I'm also happy with [\\/]. It does the same with
less (we win!) ;) ptal!

[danakj, 2015-01-31 01:32:28]

LGTM

[tfarina, 2015-02-02 13:36:36]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-02-02 13:37:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892743002/40001

[commit-bot: I haz the power, 2015-02-02 14:50:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-02 14:52:05]

Patchset 3 (id:??) landed as
https://crrev.com/26ef0f02d693f5106e4ef17748e61e8f68fb05a2
Cr-Commit-Position: refs/heads/master@{#314145}