Convert FamilyData to Skia style field names.

Convert FamilyData to Skia style field names.

The Skia convention is to prefix field names with 'f'.
This change is mostly mechanical.

Committed: https://skia.googlesource.com/skia/+/b6bed17ea81ff8fad68a7db79307bdcbcd4738a8

[bungeman-skia, 2015-01-30 23:28:39]

bungeman@google.com changed reviewers:
+ djsollen@google.com, mtklein@google.com, tomhudson@google.com

[bungeman-skia, 2015-01-30 23:28:39]

I have a refactoring tool, and I used it.

[bungeman-skia, 2015-01-30 23:28:50]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-01-30 23:29:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892733002/1

[commit-bot: I haz the power, 2015-01-30 23:29:57]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-01-31 05:29 UTC

[tomhudson, 2015-01-30 23:31:37]

lgtm

[mtklein, 2015-01-30 23:32:09]

For structs with no methods, I don't mind 'foo' instead of 'fFoo'... there's
never any ambiguity.  That said, it doesn't hurt to fFoo it up.

Out of personal interest, what tool are you using?

(lgtm)

https://codereview.chromium.org/892733002/diff/1/src/ports/SkFontConfigParser...
File src/ports/SkFontConfigParser_android.cpp (right):

https://codereview.chromium.org/892733002/diff/1/src/ports/SkFontConfigParser...
src/ports/SkFontConfigParser_android.cpp:54: FamilyData(XML_Parser parser,
SkTDArray<FontFamily*> &families)
Can it move &s and *s to the type too?

[bungeman-skia, 2015-01-30 23:33:42]

On 2015/01/30 23:32:09, mtklein wrote:
> For structs with no methods, I don't mind 'foo' instead of 'fFoo'... there's
> never any ambiguity.  That said, it doesn't hurt to fFoo it up.
> 
> Out of personal interest, what tool are you using?
> 
> (lgtm)
> 
>
https://codereview.chromium.org/892733002/diff/1/src/ports/SkFontConfigParser...
> File src/ports/SkFontConfigParser_android.cpp (right):
> 
>
https://codereview.chromium.org/892733002/diff/1/src/ports/SkFontConfigParser...
> src/ports/SkFontConfigParser_android.cpp:54: FamilyData(XML_Parser parser,
> SkTDArray<FontFamily*> &families)
> Can it move &s and *s to the type too?

I was using KDevelop. Yeah, I thought about moving * and & things to the type,
but then I felt bad about all the other ones in this file. Maybe another
cleanup.

[commit-bot: I haz the power, 2015-01-30 23:35:12]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b6bed17ea81ff8fad68a7db79307bdcbcd4738a8