Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 892693002: SVG backend in DM (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SVG backend in DM Not enabled by default, but this should get you SKPs, GMs etc for free to play with. $ out/Debug/dm -w svgs --src gm skp --config svg BUG=skia: Committed: https://skia.googlesource.com/skia/+/8a4527e98a57b1d2dd248a635f0c4fa227be2089

Patch Set 1 #

Patch Set 2 : sort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M dm/DM.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M dm/DMSrcSink.h View 1 chunk +10 lines, -0 lines 0 comments Download
M dm/DMSrcSink.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
M gyp/dm.gypi View 1 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mtklein_C
If you're interested...
5 years, 10 months ago (2015-01-30 21:24:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892693002/20001
5 years, 10 months ago (2015-01-30 21:24:48 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-01-30 21:24:48 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 10 months ago (2015-01-31 03:24:58 UTC) #8
f(malita)
lgtm Thanks! I was hesitant to make dm depend on SkSVGDevice just yet, but what ...
5 years, 10 months ago (2015-02-01 03:59:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892693002/20001
5 years, 10 months ago (2015-02-01 04:00:48 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-01 04:01:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8a4527e98a57b1d2dd248a635f0c4fa227be2089

Powered by Google App Engine
This is Rietveld 408576698