Do not clear password field in authenticator in case emails mismatch.

Do not clear password field in authenticator in case emails mismatch.

BUG=426316
Committed: https://crrev.com/7f17e9b733574b5c87f8921c3da5b5f22d5f6ac6
Cr-Commit-Position: refs/heads/master@{#314124}

[Roman Sorokin (ftl), 2015-01-30 16:14:04]

rsorokin@chromium.org changed reviewers:
+ rogerta@chromium.org, xiyuan@chromium.org

[Roman Sorokin (ftl), 2015-01-30 16:14:04]

Hi Roger,
Hi Xiyuan,

Could you please elaborate on this?
Why we are clearing password in case email stored in 'AttemptLogin' mismatch
with email in headers? We have an issue in ChromeOS in case for example we input
email 'crosmsk' and GAIA returns 'crosmsk@gmail.com' in headers.
Why we clear password in the first place? Is that because we can start new login
attempt and got headers from previous?

Thanks in advance!

[Roger Tawa OOO till Jul 10th, 2015-01-30 18:16:48]

rogerta@chromium.org changed reviewers:
+ noms@chromium.org

[Roger Tawa OOO till Jul 10th, 2015-01-30 18:16:49]

lgtm, but should get Monica to also take a look.

For my own info, why wait for contentloaded?

[xiyuan, 2015-01-30 18:19:50]

xiyuan@chromium.org changed reviewers:
- noms@chromium.org

[xiyuan, 2015-01-30 18:19:51]

LGTM

I don't remember why we clear password. It seems not necessary. If we worry
about mixing auth attempt with preivious one, we could use the attemptToken that
Gaia sends us.

Wait for contentLoad is to make sure the guest content in webview is fully
loaded and would receive the initial handshake message.

https://codereview.chromium.org/892653002/diff/1/chrome/browser/resources/gai...
File chrome/browser/resources/gaia_auth_host/authenticator.js (right):

https://codereview.chromium.org/892653002/diff/1/chrome/browser/resources/gai...
chrome/browser/resources/gaia_auth_host/authenticator.js:320: };
nit: insert a blank line after

[Roman Sorokin (ftl), 2015-02-02 08:55:54]

https://codereview.chromium.org/892653002/diff/1/chrome/browser/resources/gai...
File chrome/browser/resources/gaia_auth_host/authenticator.js (right):

https://codereview.chromium.org/892653002/diff/1/chrome/browser/resources/gai...
chrome/browser/resources/gaia_auth_host/authenticator.js:320: };
On 2015/01/30 18:19:51, xiyuan wrote:
> nit: insert a blank line after

Done.

[Roman Sorokin (ftl), 2015-02-02 08:55:59]

The CQ bit was checked by rsorokin@chromium.org

[commit-bot: I haz the power, 2015-02-02 08:57:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892653002/20001

[commit-bot: I haz the power, 2015-02-02 09:52:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-02 09:55:04]

Patchset 2 (id:??) landed as
https://crrev.com/7f17e9b733574b5c87f8921c3da5b5f22d5f6ac6
Cr-Commit-Position: refs/heads/master@{#314124}