Split property priority functions out of StyleResolver.

Split property priority functions out of StyleResolver.

This makes it easier to access the priority from other (future)
files which shouldn't depend on StyleResolver.

R=timloh@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189408

[andersr, 2015-01-30 15:52:22]

I'm trying to split up https://codereview.chromium.org/350333003 a little bit,
at least.

The plan is to later extend StylePropertyRange with the super-high-prio range,
and then use it in CascadedValues.

[Timothy Loh, 2015-02-01 22:17:09]

Might as well clean this up and use a class template:

template <CSSPropertyPriority priority>
struct CSSPropertyPriorityData {
    static const CSSPropertyId first;
    static const CSSPropertyId last;
    static ... priorityMatches(CSSPropertyId id) { .. }
};

// Pretty sure the rest of this needs to go in a .cpp file

template<> const int CSSPropertyPriorityData<HighPropertyPriority>::first =
CSSPropertyColor;
..

static_assert(...)

https://codereview.chromium.org/892643002/diff/1/Source/core/css/resolver/Sty...
File Source/core/css/resolver/StylePropertyRange.h (right):

https://codereview.chromium.org/892643002/diff/1/Source/core/css/resolver/Sty...
Source/core/css/resolver/StylePropertyRange.h:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
2015 ;)

https://codereview.chromium.org/892643002/diff/1/Source/core/css/resolver/Sty...
Source/core/css/resolver/StylePropertyRange.h:12: enum StyleApplicationPass {
Nit-picking about names since we're already touching these lines, something like
CSSPropertyPriority, {High,Low}PropertyPriority, CSSPropertyPriorityData makes
more sense to me.

https://codereview.chromium.org/892643002/diff/1/Source/core/css/resolver/Sty...
Source/core/css/resolver/StylePropertyRange.h:32: // This method returns the
first CSSPropertyId of high priority properties.
I'd describe property priority above the enum up top and remove the rest of the
comments.

[andersr, 2015-02-02 15:51:17]

On 2015/02/01 22:17:09, Timothy Loh wrote:
> Might as well clean this up and use a class template:

Sure. :)

> template <CSSPropertyPriority priority>
> struct CSSPropertyPriorityData {
>     static const CSSPropertyId first;
>     static const CSSPropertyId last;
>     static ... priorityMatches(CSSPropertyId id) { .. }
> };
> 
> // Pretty sure the rest of this needs to go in a .cpp file
> 
> template<> const int CSSPropertyPriorityData<HighPropertyPriority>::first =
> CSSPropertyColor;
> ..

Let's continue to use functions, for inlining purposes? (Unless we are using
link-time inlining on all platforms).

I avoided the name "matches" (as in "priorityMatches"), to avoid confusion with
selector matching.

PTAL.

[andersr, 2015-02-02 15:51:24]

https://codereview.chromium.org/892643002/diff/1/Source/core/css/resolver/Sty...
File Source/core/css/resolver/StylePropertyRange.h (right):

https://codereview.chromium.org/892643002/diff/1/Source/core/css/resolver/Sty...
Source/core/css/resolver/StylePropertyRange.h:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
On 2015/02/01 22:17:09, Timothy Loh wrote:
> 2015 ;)

Done.

https://codereview.chromium.org/892643002/diff/1/Source/core/css/resolver/Sty...
Source/core/css/resolver/StylePropertyRange.h:12: enum StyleApplicationPass {
On 2015/02/01 22:17:09, Timothy Loh wrote:
> Nit-picking about names since we're already touching these lines, something
like
> CSSPropertyPriority, {High,Low}PropertyPriority, CSSPropertyPriorityData makes
> more sense to me.

Done.

https://codereview.chromium.org/892643002/diff/1/Source/core/css/resolver/Sty...
Source/core/css/resolver/StylePropertyRange.h:32: // This method returns the
first CSSPropertyId of high priority properties.
On 2015/02/01 22:17:09, Timothy Loh wrote:
> I'd describe property priority above the enum up top and remove the rest of
the
> comments.

Done.

[Timothy Loh, 2015-02-03 00:40:30]

On 2015/02/02 15:51:17, andersr wrote:
> On 2015/02/01 22:17:09, Timothy Loh wrote:
> > Might as well clean this up and use a class template:
> 
> Sure. :)
> 
> > template <CSSPropertyPriority priority>
> > struct CSSPropertyPriorityData {
> >     static const CSSPropertyId first;
> >     static const CSSPropertyId last;
> >     static ... priorityMatches(CSSPropertyId id) { .. }
> > };
> > 
> > // Pretty sure the rest of this needs to go in a .cpp file
> > 
> > template<> const int CSSPropertyPriorityData<HighPropertyPriority>::first =
> > CSSPropertyColor;
> > ..
> 
> Let's continue to use functions, for inlining purposes? (Unless we are using
> link-time inlining on all platforms).
> 
> I avoided the name "matches" (as in "priorityMatches"), to avoid confusion
with
> selector matching.
> 
> PTAL.

lgtm

[andersr, 2015-02-03 10:45:14]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2015-02-03 10:46:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892643002/20001

[commit-bot: I haz the power, 2015-02-03 12:02:07]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189408