src/ic/mips64/ic-mips64.cc - Issue 892613003: MIPS: Reland "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/mips64/ic-mips64.cc

Issue 892613003: MIPS: Reland "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove printf formatter changes. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/mips64/ic-mips64.cc

diff --git a/src/ic/mips64/ic-mips64.cc b/src/ic/mips64/ic-mips64.cc

index 70aa38154a80fc7552a20059a29d60322962b515..1c5efffda8185278662e09edd71d7132fc085534 100644

--- a/src/ic/mips64/ic-mips64.cc

+++ b/src/ic/mips64/ic-mips64.cc

@@ -961,10 +961,10 @@ void PatchInlinedSmiCode(Address address, InlinedSmiCheck check) {

if (check == ENABLE_INLINED_SMI_CHECK) {

DCHECK(Assembler::IsAndImmediate(instr_at_patch));

- DCHECK_EQ(0, Assembler::GetImmediate16(instr_at_patch));

+ DCHECK_EQ(0u, Assembler::GetImmediate16(instr_at_patch));

patcher.masm()->andi(at, reg, kSmiTagMask);

} else {

- DCHECK(check == DISABLE_INLINED_SMI_CHECK);

+ DCHECK_EQ(check, DISABLE_INLINED_SMI_CHECK);

DCHECK(Assembler::IsAndImmediate(instr_at_patch));

patcher.masm()->andi(at, reg, 0);

}

« no previous file with comments | « src/ic/mips/ic-mips.cc ('k') | src/mips/code-stubs-mips.cc » ('j') | no next file with comments »