Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 892603002: Fix the test-code-stubs tests. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix the test-code-stubs tests. R=svenpanne@chromium.org Committed: https://crrev.com/5d12b2855d14b9723eb77985d92bff6a1f203f8b Cr-Commit-Position: refs/heads/master@{#26356}

Patch Set 1 #

Patch Set 2 : Stupid Windows! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M test/cctest/test-code-stubs.cc View 1 3 chunks +15 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Benedikt Meurer
5 years, 10 months ago (2015-01-30 12:52:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892603002/20001
5 years, 10 months ago (2015-01-30 13:19:55 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-01-30 13:19:56 UTC) #5
Sven Panne
lgtm
5 years, 10 months ago (2015-01-30 13:21:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892603002/20001
5 years, 10 months ago (2015-01-30 13:22:55 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-30 13:36:05 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 13:36:23 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5d12b2855d14b9723eb77985d92bff6a1f203f8b
Cr-Commit-Position: refs/heads/master@{#26356}

Powered by Google App Engine
This is Rietveld 408576698