Move some zoom constants into the headers so we don't have to duplicate the values in plugins.

Declare some zoom constants in the headers so we don't have to duplicate the values in plugins.

BUG=107063
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114586

[Lei Zhang, 2011-12-12 21:41:35]

I needed to move the constants into the headers, otherwise PPAPI plugins will
either fail to compile and/or load.

[jam, 2011-12-12 23:08:52]

On 2011/12/12 21:41:35, Lei Zhang wrote:
> I needed to move the constants into the headers, otherwise PPAPI plugins will
> either fail to compile and/or load.

you could just link against the cc files in pdf? those are self contained files?
that seems slightly better than putting constants in headers, which i believe is
against our convention?

[Lei Zhang, 2011-12-13 01:29:03]

Done.

dpranke: Can you look at the gyp file changes too? AFAIK, only the PDF plugin
will use these new targets, and I don't know if anyone builds the PDF plugin as
part of a component build.

[Dirk Pranke, 2011-12-13 03:08:32]

On 2011/12/13 01:29:03, Lei Zhang wrote:
> Done.
> 
> dpranke: Can you look at the gyp file changes too? AFAIK, only the PDF plugin
> will use these new targets, and I don't know if anyone builds the PDF plugin
as
> part of a component build.

gyp file changes look fine.

[jam, 2011-12-13 09:03:12]

On 2011/12/13 01:29:03, Lei Zhang wrote:
> Done.
> 
> dpranke: Can you look at the gyp file changes too? AFAIK, only the PDF plugin
> will use these new targets, and I don't know if anyone builds the PDF plugin
as
> part of a component build.

Since this is only used by one target, pdf plugin, why add a new target for
these two files? You can just have pdf.gyp include these files directly, which
seems just as fragile/robust :)

[Lei Zhang, 2011-12-13 21:12:39]

On 2011/12/13 09:03:12, John Abd-El-Malek wrote:
> On 2011/12/13 01:29:03, Lei Zhang wrote:
> > Done.
> > 
> > dpranke: Can you look at the gyp file changes too? AFAIK, only the PDF
plugin
> > will use these new targets, and I don't know if anyone builds the PDF plugin
> as
> > part of a component build.
> 
> Since this is only used by one target, pdf plugin, why add a new target for
> these two files? You can just have pdf.gyp include these files directly, which
> seems just as fragile/robust :)

Sure. I've uploaded patch set 3 here and updated the PDF CL as well. I suppose
an argument for patch set 2 is in case we have a new plugin in the future that
cares about the zoom settings, but we can worry about that when we get there.

[jam, 2011-12-14 23:04:15]

lgtm, thanks

[commit-bot: I haz the power, 2011-12-14 23:19:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/8926001/17006

[commit-bot: I haz the power, 2011-12-15 01:22:06]

Try job failure for 8926001-17006 (retry) on win_rel for step "cleanup_temp".
It's a second try, previously, step "cleanup_temp" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2011-12-15 01:29:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/8926001/17006

[commit-bot: I haz the power, 2011-12-15 01:36:31]

Try job failure for 8926001-17006 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-12-15 01:44:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/8926001/17006

[commit-bot: I haz the power, 2011-12-15 02:56:43]

Change committed as 114586