Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 892593002: [turbofan] Fix usage of ThisFunction parameter in OSR. (Closed)

Created:
5 years, 10 months ago by titzer
Modified:
5 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix usage of ThisFunction parameter in OSR. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/e25a0f7e4ea567125a1cf8b7687b1a1d6b17fb5e Cr-Commit-Position: refs/heads/master@{#26355}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -39 lines) Patch
M src/compiler/arm/linkage-arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/arm64/linkage-arm64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/compiler/ia32/linkage-ia32.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/linkage.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/compiler/linkage.cc View 1 4 chunks +11 lines, -9 lines 0 comments Download
M src/compiler/linkage-impl.h View 1 2 chunks +8 lines, -2 lines 0 comments Download
M src/compiler/mips/linkage-mips.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/mips64/linkage-mips64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/x64/linkage-x64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
A test/mjsunit/compiler/osr-follow.js View 1 chunk +61 lines, -0 lines 0 comments Download
M test/mjsunit/compiler/osr-forin.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-forof.js View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/compiler/osr-function.js View 1 1 chunk +31 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/osr-function-id.js View 1 chunk +33 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/osr-function-id2.js View 1 chunk +28 lines, -0 lines 0 comments Download
M test/mjsunit/compiler/osr-nested2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-nested3.js View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/compiler/osr-regex-id.js View 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
titzer
5 years, 10 months ago (2015-01-30 09:56:13 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/892593002/diff/1/src/compiler/linkage-impl.h File src/compiler/linkage-impl.h (right): https://codereview.chromium.org/892593002/diff/1/src/compiler/linkage-impl.h#newcode63 src/compiler/linkage-impl.h:63: is_osr ? stackloc(-1 - js_parameter_count) Magic "-1" is ...
5 years, 10 months ago (2015-01-30 10:06:02 UTC) #2
titzer
On 2015/01/30 10:06:02, Michael Starzinger wrote: > LGTM. > > https://codereview.chromium.org/892593002/diff/1/src/compiler/linkage-impl.h > File src/compiler/linkage-impl.h (right): ...
5 years, 10 months ago (2015-01-30 12:18:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892593002/20001
5 years, 10 months ago (2015-01-30 12:19:26 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-30 13:09:40 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 13:09:52 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e25a0f7e4ea567125a1cf8b7687b1a1d6b17fb5e
Cr-Commit-Position: refs/heads/master@{#26355}

Powered by Google App Engine
This is Rietveld 408576698