Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1698)

Unified Diff: pkg/compiler/lib/src/resolution/members.dart

Issue 892583002: Support async getters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/scanner/parser.dart » ('j') | pkg/compiler/lib/src/scanner/parser.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/members.dart
diff --git a/pkg/compiler/lib/src/resolution/members.dart b/pkg/compiler/lib/src/resolution/members.dart
index 52ad563fcc8a3e85e1ac09b2f920546e5dd728bc..7d0c0b89bd47193682e8864f0087208ae22839d5 100644
--- a/pkg/compiler/lib/src/resolution/members.dart
+++ b/pkg/compiler/lib/src/resolution/members.dart
@@ -4800,9 +4800,10 @@ class ConstructorResolver extends CommonResolverVisitor<Element> {
throw 'not supported';
}
- failOrReturnErroneousElement(Element enclosing, Node diagnosticNode,
- String targetName, MessageKind kind,
- Map arguments) {
+ failOrReturnErroneousConstructorElement(
+ Element enclosing, Node diagnosticNode,
+ String targetName, MessageKind kind,
+ Map arguments) {
if (kind == MessageKind.CANNOT_FIND_CONSTRUCTOR) {
registry.registerThrowNoSuchMethod();
} else {
@@ -4813,7 +4814,8 @@ class ConstructorResolver extends CommonResolverVisitor<Element> {
} else {
compiler.reportWarning(diagnosticNode, kind, arguments);
}
- return new ErroneousElementX(kind, arguments, targetName, enclosing);
+ return new ErroneousConstructorElementX(
+ kind, arguments, targetName, enclosing);
}
FunctionElement resolveConstructor(ClassElement cls,
@@ -4825,7 +4827,7 @@ class ConstructorResolver extends CommonResolverVisitor<Element> {
String fullConstructorName = Elements.constructorNameForDiagnostics(
cls.name,
constructorName);
- return failOrReturnErroneousElement(
+ return failOrReturnErroneousConstructorElement(
cls,
diagnosticNode,
fullConstructorName,
@@ -4862,7 +4864,7 @@ class ConstructorResolver extends CommonResolverVisitor<Element> {
// The unnamed constructor may not exist, so [e] may become unresolved.
element = resolveConstructor(cls, diagnosticNode, '');
} else {
- element = failOrReturnErroneousElement(
+ element = failOrReturnErroneousConstructorElement(
element, diagnosticNode, element.name, MessageKind.NOT_A_TYPE,
{'node': diagnosticNode});
}
@@ -4912,7 +4914,7 @@ class ConstructorResolver extends CommonResolverVisitor<Element> {
element = prefix.lookupLocalMember(name.source);
element = Elements.unwrap(element, compiler, node);
if (element == null) {
- return failOrReturnErroneousElement(
+ return failOrReturnErroneousConstructorElement(
resolver.enclosingElement, name,
name.source,
MessageKind.CANNOT_RESOLVE,
@@ -4933,9 +4935,10 @@ class ConstructorResolver extends CommonResolverVisitor<Element> {
registry.useElement(node, element);
// TODO(johnniwinther): Change errors to warnings, cf. 11.11.1.
if (element == null) {
- return failOrReturnErroneousElement(resolver.enclosingElement, node, name,
- MessageKind.CANNOT_RESOLVE,
- {'name': name});
+ return failOrReturnErroneousConstructorElement(
+ resolver.enclosingElement, node, name,
+ MessageKind.CANNOT_RESOLVE,
+ {'name': name});
} else if (element.isErroneous) {
return element;
} else if (element.isTypedef) {
« no previous file with comments | « no previous file | pkg/compiler/lib/src/scanner/parser.dart » ('j') | pkg/compiler/lib/src/scanner/parser.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698