Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: content/renderer/service_worker/embedded_worker_context_message_filter.cc

Issue 892543002: workers: Introduce a WorkerMessageFilter to ease routing/processing worker messages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/service_worker/embedded_worker_context_message_filter.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/service_worker/embedded_worker_context_message_filter.cc
diff --git a/content/renderer/service_worker/embedded_worker_context_message_filter.cc b/content/renderer/service_worker/embedded_worker_context_message_filter.cc
index cbc141df56a63514548058b1ab89fbf81252f0d5..b90e24de5857eaaa528ad94f1ccaf926d9af37d5 100644
--- a/content/renderer/service_worker/embedded_worker_context_message_filter.cc
+++ b/content/renderer/service_worker/embedded_worker_context_message_filter.cc
@@ -4,45 +4,37 @@
#include "content/renderer/service_worker/embedded_worker_context_message_filter.h"
-#include "base/message_loop/message_loop_proxy.h"
#include "content/child/child_thread.h"
-#include "content/child/thread_safe_sender.h"
-#include "content/child/worker_thread_task_runner.h"
#include "content/renderer/service_worker/embedded_worker_context_client.h"
#include "ipc/ipc_message_macros.h"
namespace content {
EmbeddedWorkerContextMessageFilter::EmbeddedWorkerContextMessageFilter()
- : main_thread_loop_proxy_(base::MessageLoopProxy::current()),
- thread_safe_sender_(ChildThread::current()->thread_safe_sender()) {}
+ : WorkerThreadMessageFilter(ChildThread::current()->thread_safe_sender()) {
+}
EmbeddedWorkerContextMessageFilter::~EmbeddedWorkerContextMessageFilter() {}
-base::TaskRunner*
-EmbeddedWorkerContextMessageFilter::OverrideTaskRunnerForMessage(
- const IPC::Message& msg) {
- if (IPC_MESSAGE_CLASS(msg) != EmbeddedWorkerContextMsgStart)
- return NULL;
- int ipc_thread_id = 0;
- const bool success = PickleIterator(msg).ReadInt(&ipc_thread_id);
- DCHECK(success);
- if (!ipc_thread_id)
- return main_thread_loop_proxy_.get();
- return new WorkerThreadTaskRunner(ipc_thread_id);
+bool EmbeddedWorkerContextMessageFilter::ShouldHandleMessage(
+ const IPC::Message& msg) const {
+ return IPC_MESSAGE_CLASS(msg) == EmbeddedWorkerContextMsgStart;
}
-bool EmbeddedWorkerContextMessageFilter::OnMessageReceived(
+void EmbeddedWorkerContextMessageFilter::OnFilteredMessageReceived(
const IPC::Message& msg) {
- if (IPC_MESSAGE_CLASS(msg) != EmbeddedWorkerContextMsgStart)
- return false;
EmbeddedWorkerContextClient* client =
EmbeddedWorkerContextClient::ThreadSpecificInstance();
- if (!client) {
+ if (!client)
LOG(ERROR) << "Stray message is sent to nonexistent worker";
- return true;
- }
- return client->OnMessageReceived(msg);
+ else
+ client->OnMessageReceived(msg);
+}
+
+bool EmbeddedWorkerContextMessageFilter::GetWorkerThreadIdForMessage(
+ const IPC::Message& msg,
+ int* ipc_thread_id) {
+ return PickleIterator(msg).ReadInt(ipc_thread_id);
}
} // namespace content
« no previous file with comments | « content/renderer/service_worker/embedded_worker_context_message_filter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698