Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 892533002: Initial SVG backend stubbing (Closed)

Created:
5 years, 10 months ago by f(malita)
Modified:
5 years, 10 months ago
Reviewers:
jcgregorio, caryclark, reed1
CC:
reviews_skia.org, shawcroft_google.com
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Initial SVG backend stubbing This adds SkSVGDevice and a small utility for converting SKP files to SVG (skp2svg). R=reed@google.com,jcgregorio@google.com BUG=skia:3368 Committed: https://skia.googlesource.com/skia/+/93957f4e8087774f35e2d1c3ff38ec7da306551d

Patch Set 1 #

Patch Set 2 : optional output file arg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -0 lines) Patch
A experimental/svg/SkSVGDevice.h View 1 chunk +72 lines, -0 lines 0 comments Download
A experimental/svg/SkSVGDevice.cpp View 1 chunk +187 lines, -0 lines 0 comments Download
A experimental/svg/skp2svg.cpp View 1 1 chunk +70 lines, -0 lines 0 comments Download
M gyp/tools.gyp View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
f(malita)
Only solid color (transformed) paths and rects are supported atm (OTOH, it's pretty impressive what ...
5 years, 10 months ago (2015-01-30 15:00:34 UTC) #3
reed1
When we expose this, do you think it is... - a surface - a document ...
5 years, 10 months ago (2015-01-30 15:59:06 UTC) #4
reed1
lgtm
5 years, 10 months ago (2015-01-30 15:59:10 UTC) #5
f(malita)
On 2015/01/30 15:59:06, reed1 wrote: > When we expose this, do you think it is... ...
5 years, 10 months ago (2015-01-30 16:05:20 UTC) #6
mtklein
> My first thought was for it to be a canvas, constructed via a specialized ...
5 years, 10 months ago (2015-01-30 16:14:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892533002/20001
5 years, 10 months ago (2015-01-30 16:57:46 UTC) #9
reed1
I am still good that pictures != surface/image. I look at PDF, and our decision ...
5 years, 10 months ago (2015-01-30 16:58:10 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 17:03:34 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/93957f4e8087774f35e2d1c3ff38ec7da306551d

Powered by Google App Engine
This is Rietveld 408576698