Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 89253002: Remove ExtensionPrefFactory's dependency on Profile. (Closed)

Created:
7 years ago by Daniel Erat
Modified:
7 years ago
Reviewers:
miket_OOO, benwells
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, tfarina, nhiroki, chromium-apps-reviews_chromium.org, kinuko+watch, James Cook
Visibility:
Public.

Description

Remove ExtensionPrefFactory's dependency on Profile. Move the code that checks whether the command-line flag or pref to disable extensions is set into ExtensionsBrowserClient, and make ExtensionPrefFactory work with a BrowserContext instead of requiring a Profile. BUG=313284 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238243

Patch Set 1 #

Patch Set 2 : remove Profile references from ExtensionPrefValueMapFactory #

Patch Set 3 : fix ExtensionServiceTestSimple.Enabledness #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -31 lines) Patch
M apps/app_restore_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M apps/app_restore_service_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M apps/saved_files_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.h View 1 2 3 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_pref_value_map_factory.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_pref_value_map_factory.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_prefs.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_factory.cc View 1 2 2 chunks +12 lines, -15 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_sync_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model_factory.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/browser/extensions_browser_client.h View 1 2 3 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Daniel Erat
fix ExtensionServiceTestSimple.Enabledness
7 years ago (2013-11-26 23:24:05 UTC) #1
Daniel Erat
7 years ago (2013-11-26 23:26:12 UTC) #2
Daniel Erat
7 years ago (2013-12-02 14:56:25 UTC) #3
benwells
sorry, missed this. lgtm
7 years ago (2013-12-02 21:26:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/89253002/60001
7 years ago (2013-12-02 21:31:13 UTC) #5
miket_OOO
lgtm
7 years ago (2013-12-02 21:50:02 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-03 00:31:05 UTC) #7
Message was sent while issue was closed.
Change committed as 238243

Powered by Google App Engine
This is Rietveld 408576698