Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 892513004: Revert of Suppress accessibility events when user is navigating away. (Closed)

Created:
5 years, 10 months ago by kelvinp
Modified:
5 years, 10 months ago
Reviewers:
dmazzoni, nasko
CC:
chromium-reviews, creis+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Suppress accessibility events when user is navigating away. (patchset #6 id:100001 of https://codereview.chromium.org/830053004/) Reason for revert: NavigationAccessibilityTest.TestNavigateToNewUrl is failing on Win7 Tests (dbg)(1). Sample failure: http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/35087 Original issue's description: > Suppress accessibility events when user is navigating away. > > When the user navigates to a new page, stop sending accessibility > events on the old page. > > BUG=421116, 450409 > > Committed: https://crrev.com/6ce40a1e561892849c1f6ac070dda140f6cc0115 > Cr-Commit-Position: refs/heads/master@{#314812} TBR=nasko@chromium.org,dmazzoni@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=421116, 450409 Committed: https://crrev.com/7fcb729df6369250da0eccb113a64073e272de39 Cr-Commit-Position: refs/heads/master@{#314884}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -328 lines) Patch
D chrome/browser/ui/views/accessibility/navigation_accessibility_uitest_win.cc View 1 chunk +0 lines, -255 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.h View 2 chunks +0 lines, -9 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.cc View 3 chunks +0 lines, -18 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_win.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_win.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 4 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kelvinp
Created Revert of Suppress accessibility events when user is navigating away.
5 years, 10 months ago (2015-02-05 21:36:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892513004/1
5 years, 10 months ago (2015-02-05 21:36:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 21:37:54 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 21:40:16 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7fcb729df6369250da0eccb113a64073e272de39
Cr-Commit-Position: refs/heads/master@{#314884}

Powered by Google App Engine
This is Rietveld 408576698