Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 892503002: Revert of Revert of IPC::ChannelMojo: Make IPC handling robust against bad messages. (Closed)

Created:
5 years, 10 months ago by inferno
Modified:
5 years, 10 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of IPC::ChannelMojo: Make IPC handling robust against bad messages. (patchset #1 id:1 of https://codereview.chromium.org/883373002/) Reason for revert: Wrong revert, ipc fuzzer broke because of something else. Original issue's description: > Revert of IPC::ChannelMojo: Make IPC handling robust against bad messages. (patchset #3 id:40001 of https://codereview.chromium.org/725733002/) > > Reason for revert: > Broke ipc fuzzer > > Original issue's description: > > IPC::ChannelMojo: Make IPC handling robust against bad messages. > > > > This change replaces some DCHECK()s with real error handling. > > They happen when it receives broken messages. > > > > BUG=428800 > > R=viettrungluu@chromium.org > > > > Committed: https://crrev.com/185ffdf58f85e47db9666d2ad9b80ff9bd7fa54b > > Cr-Commit-Position: refs/heads/master@{#304102} > > TBR=viettrungluu@chromium.org,morrita@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=428800 > > Committed: https://crrev.com/726621f93d2802dfc2c90732c7133145c9854e38 > Cr-Commit-Position: refs/heads/master@{#313778} TBR=viettrungluu@chromium.org,morrita@chromium.org,tsepez@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=428800 Committed: https://crrev.com/1f289ac93a7e90ca9445f97ea58f5e3961bd9539 Cr-Commit-Position: refs/heads/master@{#313780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M ipc/mojo/ipc_mojo_bootstrap.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.cc View 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
inferno
Created Revert of Revert of IPC::ChannelMojo: Make IPC handling robust against bad messages.
5 years, 10 months ago (2015-01-29 20:43:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892503002/1
5 years, 10 months ago (2015-01-29 20:47:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 20:48:22 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 20:50:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f289ac93a7e90ca9445f97ea58f5e3961bd9539
Cr-Commit-Position: refs/heads/master@{#313780}

Powered by Google App Engine
This is Rietveld 408576698