Fix "choose what to sync" in the webview signin

Fix "choose what to sync" in the webview signin

When "Choose what to sync" is clicked, we change the source to 3 in the
gaia continue url.

BUG=452440
Committed: https://crrev.com/ef953dd4a7075adbda2cb5d6fdb366fc9bf4e2e5
Cr-Commit-Position: refs/heads/master@{#313812}

[noms (inactive), 2015-01-29 19:49:25]

noms@chromium.org changed reviewers:
+ rogerta@chromium.org, xiyuan@chromium.org

[noms (inactive), 2015-01-29 19:49:25]

PTAL. Thanks!

[xiyuan, 2015-01-29 20:16:28]

https://codereview.chromium.org/892493002/diff/1/chrome/browser/resources/gai...
File chrome/browser/resources/gaia_auth_host/authenticator.js (right):

https://codereview.chromium.org/892493002/diff/1/chrome/browser/resources/gai...
chrome/browser/resources/gaia_auth_host/authenticator.js:270: var location =
unescape(header.value);
nit: prefer decodeURIComponent over unescape.

https://codereview.chromium.org/892493002/diff/1/chrome/browser/resources/gai...
chrome/browser/resources/gaia_auth_host/authenticator.js:271:
this.chooseWhatToSync_ = (location.indexOf(CHOOSE_WHAT_TO_SYNC) != -1);
This seems to be a bit brittle. What if we have 'source=30' in the future? 

How about
  this.chooseWhatToSync_ = !!location.match(/(\?|&)source=3($|&)/);

[noms (inactive), 2015-01-29 21:46:47]

https://codereview.chromium.org/892493002/diff/1/chrome/browser/resources/gai...
File chrome/browser/resources/gaia_auth_host/authenticator.js (right):

https://codereview.chromium.org/892493002/diff/1/chrome/browser/resources/gai...
chrome/browser/resources/gaia_auth_host/authenticator.js:270: var location =
unescape(header.value);
On 2015/01/29 20:16:28, xiyuan wrote:
> nit: prefer decodeURIComponent over unescape.

Ha! I actually had decodeURI initially, and thought unescape was the chrome way.
Done!

https://codereview.chromium.org/892493002/diff/1/chrome/browser/resources/gai...
chrome/browser/resources/gaia_auth_host/authenticator.js:271:
this.chooseWhatToSync_ = (location.indexOf(CHOOSE_WHAT_TO_SYNC) != -1);
On 2015/01/29 20:16:28, xiyuan wrote:
> This seems to be a bit brittle. What if we have 'source=30' in the future? 
> 
> How about
>   this.chooseWhatToSync_ = !!location.match(/(\?|&)source=3($|&)/);

It would be uhhh an easter egg. Done.

[xiyuan, 2015-01-29 21:48:55]

lgtm

[Roger Tawa OOO till Jul 10th, 2015-01-29 22:00:01]

lgtm

[noms (inactive), 2015-01-29 22:00:26]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2015-01-29 22:01:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892493002/20001

[commit-bot: I haz the power, 2015-01-29 22:48:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-29 22:49:21]

Patchset 2 (id:??) landed as
https://crrev.com/ef953dd4a7075adbda2cb5d6fdb366fc9bf4e2e5
Cr-Commit-Position: refs/heads/master@{#313812}