src/opts/SkFontHost_FreeType_common_opts_neon.h - Issue 892453002: neon code for bgra to rgba conversion for copyFTBitmap

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/opts/SkFontHost_FreeType_common_opts_neon.h

Issue 892453002: neon code for bgra to rgba conversion for copyFTBitmap Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 void BGRA2RGBA_Neon(const uint8_t* src, uint8_t* dst, size_t height, const size_ t width, const size_t dstRowBytes, const int srcPitch);
	reed1 2015/01/29 15:47:20 Please document this call: - why does it take byte Please document this call: - why does it take bytes instead of uint32_t? - skia's convention is to use "int" for counts such as width and height, and only use size_t for byte counts - skia's convention reserves "const" for only refs and pointers. frederic.ma 2015/01/29 18:33:09 Done. Show quoted text On 2015/01/29 15:47:20, reed1 wrote: > Please document this call: > - why does it take bytes instead of uint32_t? > - skia's convention is to use "int" for counts such as width and height, and > only use size_t for byte counts > - skia's convention reserves "const" for only refs and pointers. Done.
OLD	NEW