Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 892443002: Add UMA histograms for tracking empty usernames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 46f71a99d38dc07a9c9f82eee752085e781747b7..998f6c0ca16878e738eae253c76eaeb722c08f2d 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -23242,6 +23242,22 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="PasswordManager.EmptyUsernames.CountInDatabase">
+ <owner>vasilii@chromium.org</owner>
+ <summary>
+ Number of password forms with empty username in the Password Store. This is
+ recorded on startup.
+ </summary>
+</histogram>
+
+<histogram name="PasswordManager.EmptyUsernames.OfferedToSave"
+ enum="PasswordManagerShowEmptyUsername">
+ <owner>vasilii@chromium.org</owner>
+ <summary>
+ When offering to save a password, whether the username is empty.
+ </summary>
+</histogram>
+
<histogram name="PasswordManager.Enabled" enum="BooleanEnabled">
<owner>dubroy@chromium.org</owner>
<owner>vabr@chromium.org</owner>
@@ -53837,6 +53853,11 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="2" label="Match"/>
</enum>
+<enum name="PasswordManagerShowEmptyUsername" type="int">
+ <int value="0" label="Non empty username"/>
Ilya Sherman 2015/01/30 22:13:46 nit: "Non empty" -> "Non-empty"
vasilii 2015/02/02 10:03:37 Done.
+ <int value="1" label="Empty username"/>
+</enum>
+
<enum name="PasswordManagerSyncingAccountState" type="int">
<summary>
The value is a combination of the current sync state and if the user has
« no previous file with comments | « components/password_manager/core/browser/password_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698