Add UMA histograms for tracking empty usernames.

Add UMA histograms for tracking empty usernames.

BUG=452479
Committed: https://crrev.com/52eae3f84152c1ce98a58d376350550c6be88fbc
Cr-Commit-Position: refs/heads/master@{#314131}

[vasilii, 2015-01-29 14:54:16]

vasilii@chromium.org changed reviewers:
+ vabr@chromium.org

[vasilii, 2015-01-29 14:54:50]

vasilii@chromium.org changed reviewers:
+ isherman@chromium.org

[vasilii, 2015-01-29 14:54:51]

Hi guys,

please review the CL.

[vabr (Chromium), 2015-01-29 15:40:23]

Hi Vasilii,
Please see my comments.

Cheers,
Vaclav

https://codereview.chromium.org/892443002/diff/1/chrome/browser/ui/passwords/...
File chrome/browser/ui/passwords/manage_passwords_ui_controller.cc (right):

https://codereview.chromium.org/892443002/diff/1/chrome/browser/ui/passwords/...
chrome/browser/ui/passwords/manage_passwords_ui_controller.cc:116:
UMA_HISTOGRAM_BOOLEAN("PasswordManager.OfferSaveEmptyUsername",
You might consider putting this in PasswordManager::AskUserOrSavePassword, so
that it works also with the infobar and on mobile.

https://codereview.chromium.org/892443002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/892443002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:23266: +    Number of password forms
with empty username in the Password Store.
Could you please insert a <!--comment--> with a TODO pointing to the bug for
adding UMA reports to PasswordStoreX?

[Ilya Sherman, 2015-01-29 20:31:09]

https://codereview.chromium.org/892443002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/892443002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:23263: +<histogram
name="PasswordManager.NumEmptyUsernames">
nit: Suggested name: "PasswordManager.EmptyUsernames.CountInDatabase".

https://codereview.chromium.org/892443002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:23266: +    Number of password forms
with empty username in the Password Store.
Please document when this metric is recorded -- at startup?  On access to the
DB?  Other?

https://codereview.chromium.org/892443002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:23306: +<histogram
name="PasswordManager.OfferSaveEmptyUsername">
Suggested name: "PasswordManager.EmptyUsernames.OfferedToSave".  The main part
of these suggestions is moving "EmptyUsernames" to the front of the name, so
that the two related stats are grouped together hierarchically and
alphabetically.

https://codereview.chromium.org/892443002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:23306: +<histogram
name="PasswordManager.OfferSaveEmptyUsername">
Please associate an enum that's specifically relevant to this histogram.

https://codereview.chromium.org/892443002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:23309: +    Indicates if the user is
proposed to save an empty username.
Please document when this metric is recorded.  So, something like: "When
offering to save a password, whether the username is empty." or "How frequently
users are prompted to save empty usernames.  Recorded each time Chrome offers to
save a password." or something along those lines.

[vasilii, 2015-01-30 12:35:42]

https://codereview.chromium.org/892443002/diff/1/chrome/browser/ui/passwords/...
File chrome/browser/ui/passwords/manage_passwords_ui_controller.cc (right):

https://codereview.chromium.org/892443002/diff/1/chrome/browser/ui/passwords/...
chrome/browser/ui/passwords/manage_passwords_ui_controller.cc:116:
UMA_HISTOGRAM_BOOLEAN("PasswordManager.OfferSaveEmptyUsername",
On 2015/01/29 15:40:23, vabr (Chromium) wrote:
> You might consider putting this in PasswordManager::AskUserOrSavePassword, so
> that it works also with the infobar and on mobile.

Done.

https://codereview.chromium.org/892443002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/892443002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:23263: +<histogram
name="PasswordManager.NumEmptyUsernames">
On 2015/01/29 20:31:09, Ilya Sherman wrote:
> nit: Suggested name: "PasswordManager.EmptyUsernames.CountInDatabase".

Done.

https://codereview.chromium.org/892443002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:23266: +    Number of password forms
with empty username in the Password Store.
On 2015/01/29 20:31:09, Ilya Sherman wrote:
> Please document when this metric is recorded -- at startup?  On access to the
> DB?  Other?

Done.

https://codereview.chromium.org/892443002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:23266: +    Number of password forms
with empty username in the Password Store.
On 2015/01/29 15:40:23, vabr (Chromium) wrote:
> Could you please insert a <!--comment--> with a TODO pointing to the bug for
> adding UMA reports to PasswordStoreX?

I didn't find similar comments in the xml. I don't think it's a problem for this
particular diagram, for others it may be worse.

https://codereview.chromium.org/892443002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:23306: +<histogram
name="PasswordManager.OfferSaveEmptyUsername">
On 2015/01/29 20:31:09, Ilya Sherman wrote:
> Suggested name: "PasswordManager.EmptyUsernames.OfferedToSave".  The main part
> of these suggestions is moving "EmptyUsernames" to the front of the name, so
> that the two related stats are grouped together hierarchically and
> alphabetically.

Done.

https://codereview.chromium.org/892443002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:23306: +<histogram
name="PasswordManager.OfferSaveEmptyUsername">
On 2015/01/29 20:31:09, Ilya Sherman wrote:
> Please associate an enum that's specifically relevant to this histogram.

Done.

https://codereview.chromium.org/892443002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:23309: +    Indicates if the user is
proposed to save an empty username.
On 2015/01/29 20:31:09, Ilya Sherman wrote:
> Please document when this metric is recorded.  So, something like: "When
> offering to save a password, whether the username is empty." or "How
frequently
> users are prompted to save empty usernames.  Recorded each time Chrome offers
to
> save a password." or something along those lines.

Done.

[Ilya Sherman, 2015-01-30 22:13:46]

histograms LGTM % a nit:

https://codereview.chromium.org/892443002/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/892443002/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:53857: +  <int value="0" label="Non
empty username"/>
nit: "Non empty" -> "Non-empty"

[vasilii, 2015-02-02 10:03:37]

Vaclav?

https://codereview.chromium.org/892443002/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/892443002/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:53857: +  <int value="0" label="Non
empty username"/>
On 2015/01/30 22:13:46, Ilya Sherman wrote:
> nit: "Non empty" -> "Non-empty"

Done.

[vabr (Chromium), 2015-02-02 11:35:01]

LGTM with a nit.

Thanks!
Vaclav

https://codereview.chromium.org/892443002/diff/40001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/892443002/diff/40001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:23255: +    Number of password forms
with empty username in the Password Store. This is
Please change Password Store to Login Database, to match the histogram name, and
the site of collection.

[vasilii, 2015-02-02 11:43:14]

https://codereview.chromium.org/892443002/diff/40001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/892443002/diff/40001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:23255: +    Number of password forms
with empty username in the Password Store. This is
On 2015/02/02 11:35:01, vabr (Chromium) wrote:
> Please change Password Store to Login Database, to match the histogram name,
and
> the site of collection.

Done.

[vasilii, 2015-02-02 11:43:19]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2015-02-02 11:44:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892443002/60001

[commit-bot: I haz the power, 2015-02-02 12:38:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-02 12:38:52]

Patchset 4 (id:??) landed as
https://crrev.com/52eae3f84152c1ce98a58d376350550c6be88fbc
Cr-Commit-Position: refs/heads/master@{#314131}