chrome/browser/metrics/metrics_log.cc - Issue 89243003: Move EmptyString, kWhitespace and the BOM to base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_log.cc

Issue 89243003: Move EmptyString, kWhitespace and the BOM to base. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/metrics_log.cc

diff --git a/chrome/browser/metrics/metrics_log.cc b/chrome/browser/metrics/metrics_log.cc

index 8334e1edabddda34e7b47648cbd823f6a0b84270..8c6a49dc350b63abb7cf272a341099cf0e686ba4 100644

--- a/chrome/browser/metrics/metrics_log.cc

+++ b/chrome/browser/metrics/metrics_log.cc

@@ -812,9 +812,9 @@ void MetricsLog::RecordProfilerData(

void MetricsLog::RecordOmniboxOpenedURL(const OmniboxLog& log) {

DCHECK(!locked());

- std::vector<string16> terms;

+ std::vector<base::string16> terms;

const int num_terms =

- static_cast<int>(Tokenize(log.text, kWhitespaceUTF16, &terms));

+ static_cast<int>(Tokenize(log.text, base::kWhitespaceUTF16, &terms));

OmniboxEventProto* omnibox_event = uma_proto()->add_omnibox_event();

omnibox_event->set_time(MetricsLogBase::GetCurrentTime());