Issue 89243003: Move EmptyString, kWhitespace and the BOM to base.

Issue 89243003: Move EmptyString, kWhitespace and the BOM to base. (Closed)

Created:
7 years ago by brettw

Modified:
7 years ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, jbauman+watch_chromium.org, amit, ilevy-cc_chromium.org, browser-components-watch_chromium.org, sievers+watch_chromium.org, yfriedman+watch_chromium.org, aandrey+blink_chromium.org, Ilya Sherman, danakj+watch_chromium.org, frankf+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, vsevik, jar (doing other things), benquan, stevenjb+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, Dane Wallinga, cc-bugs_chromium.org, tbarzic+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., craigdh+watch_chromium.org, feature-media-reviews_chromium.org, paulirish+reviews_chromium.org, bulach+watch_chromium.org, oshima+watch_chromium.org, kalyank, piman+watch_chromium.org, pfeldman, rouslan+autofillwatch_chromium.org, Ian Vollick, tfarina, mcasas+watch_chromium.org, yurys, asvitkine+watch_chromium.org, robertshield, ben+ash_chromium.org, dyu1, grt+watch_chromium.org, estade+watch_chromium.org, klundberg+watch_chromium.org, James Su, wjia+watch_chromium.org, jshin+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move EmptyString, kWhitespace and the BOM to base. This moves EmptyString*, kWhitespace*, and the UTF 8 Byte Order Marker to the base:: namespace. Many of them just got changed to a default-constructed string when a reference was not required. I qualified some string16s with base:: when I was changing adjacent code. I need to do another pass to finish these up. BUG= TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238032

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -111 lines)			Patch
M	ash/shell/launcher_delegate_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ash/test/test_launcher_delegate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/strings/string_util.h	View		2 chunks	+24 lines, -17 lines	0 comments	Download
M	base/strings/string_util.cc	View		4 chunks	+8 lines, -9 lines	0 comments	Download
M	base/strings/string_util_constants.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_input.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/autocomplete/keyword_provider.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/background/background_contents_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/imageburner/burn_manager.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/settings/device_settings_test_helper.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/drive/drive_api_util.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/user_script_master.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/history/url_index_private_data.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/metrics/metrics_log.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/policy/cloud/component_cloud_policy_store.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/cloud/mock_device_management_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/signin/token_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/ash/multi_user/multi_user_window_manager_stub.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/omnibox/location_bar_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_view_views.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/api/i18n/default_locale_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/omnibox/omnibox_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/permissions/socket_permission_entry.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/chrome_render_view_observer.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome_frame/chrome_active_document.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome_frame/test/automation_client_mock.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/test/test_with_web_server.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/dbus/fake_session_manager_client.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chromeos/disks/disk_mount_manager.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	components/autofill/core/browser/autofill_field.cc	View		1 chunk	+6 lines, -5 lines	0 comments	Download
M	content/browser/renderer_host/java/java_method.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/android/address_parser.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/common/android/address_parser_unittest.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/renderer/media/crypto/proxy_decryptor.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/browser/file_highlighter_unittest.cc	View		4 chunks	+7 lines, -7 lines	0 comments	Download
M	extensions/common/manifest_handlers/csp_info.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	google_apis/gaia/google_service_auth_error.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/service/gpu_tracer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	media/base/android/media_drm_bridge.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/ftp/ftp_network_transaction.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/url_request/url_request_context.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/url_request/url_request_http_job.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/url_request/url_request_test_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/url_request/url_request_unittest.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	testing/android/native_test_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/compositor/compositor.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/oak/oak_aura_window_display.cc	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download