Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 892423005: Remove unnecessary assignment (Closed)

Created:
5 years, 10 months ago by qiankun
Modified:
5 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove unnecessary assignment BUG=skia: Committed: https://skia.googlesource.com/skia/+/e3ecde1205d7698eb6266cdc4d43e4034b3f30d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/core/SkScan_Path.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
qiankun
PTAL.
5 years, 10 months ago (2015-02-09 10:20:14 UTC) #2
reed1
left and rite are referenced on line 280? Don't we need to update them?
5 years, 10 months ago (2015-02-09 15:00:33 UTC) #3
reed1
Ah, they're both zero! Good catch. lgtm
5 years, 10 months ago (2015-02-09 15:01:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892423005/1
5 years, 10 months ago (2015-02-09 15:02:23 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 15:08:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e3ecde1205d7698eb6266cdc4d43e4034b3f30d6

Powered by Google App Engine
This is Rietveld 408576698