Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: net/url_request/url_request_http_job.cc

Issue 892413007: DumpWithoutCrashing() if URLRequestHttpJob is killed while waiting for callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@432398-cookie-settings-incognito
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index 68858c147586fc902d58c50f946829c46bf543e1..f44d28b6d86d8e1fe25f6be514af6f2b48a001db 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -10,6 +10,7 @@
#include "base/command_line.h"
#include "base/compiler_specific.h"
#include "base/debug/alias.h"
+#include "base/debug/dump_without_crashing.h"
#include "base/file_version_info.h"
#include "base/message_loop/message_loop.h"
#include "base/metrics/field_trial.h"
@@ -289,6 +290,12 @@ void URLRequestHttpJob::Start() {
}
void URLRequestHttpJob::Kill() {
+ if (awaiting_callback_) {
+ // TODO(battre) crbug.com/289715
+ // Simulate a crash to see who kills the job while it is waiting for a
+ // callback. This should not happen, see URLRequest::OrphanJob().
+ base::debug::DumpWithoutCrashing();
+ }
if (!transaction_.get())
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698