Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Issue 892413007: DumpWithoutCrashing() if URLRequestHttpJob is killed while waiting for callback (Closed)

Created:
5 years, 10 months ago by battre
Modified:
5 years, 10 months ago
Reviewers:
mmenke
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@432398-cookie-settings-incognito
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DumpWithoutCrashing() if URLRequestHttpJob is killed while waiting for callback BUG=432398 Committed: https://crrev.com/cb3d31dcc6d70edcf3f53e028fe9ec650f228c64 Cr-Commit-Position: refs/heads/master@{#315052}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M net/url_request/url_request_http_job.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
battre
Hi Matt, could you please review this? Thanks, Dominic
5 years, 10 months ago (2015-02-06 15:23:17 UTC) #2
mmenke
On 2015/02/06 15:23:17, battre wrote: > Hi Matt, > > could you please review this? ...
5 years, 10 months ago (2015-02-06 15:35:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892413007/1
5 years, 10 months ago (2015-02-06 16:10:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 17:21:10 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cb3d31dcc6d70edcf3f53e028fe9ec650f228c64 Cr-Commit-Position: refs/heads/master@{#315052}
5 years, 10 months ago (2015-02-06 17:22:23 UTC) #7
battre
5 years, 10 months ago (2015-02-09 09:50:03 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/906223002/ by battre@chromium.org.

The reason for reverting is: Remove DumpWithoutCrashing() from URLRequestHttpJob
again.

See crbug.com/432398 for stacktraces uncovered by this..

Powered by Google App Engine
This is Rietveld 408576698