src/heap/heap.cc - Issue 892413006: Check that we're called on a valid heap during idle notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 892413006: Check that we're called on a valid heap during idle notifications (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index d5417acf17ae696d7f83fc3172ea2c83b6bcaab6..613e6b9662f9286f0fc51eba71058bc05096a1ff 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -4538,6 +4538,7 @@ bool Heap::IdleNotification(int idle_time_in_ms) {

bool Heap::IdleNotification(double deadline_in_seconds) {

+ CHECK(HasBeenSetUp()); // http://crbug.com/425035

double deadline_in_ms =

deadline_in_seconds *

static_cast<double>(base::Time::kMillisecondsPerSecond);

« no previous file with comments | « no previous file | no next file » | no next file with comments »