Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 892403002: Revert of [android] Remove libaddressinput Java widget. (Closed)

Created:
5 years, 10 months ago by perezju
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [android] Remove libaddressinput Java widget. (patchset #1 id:1 of https://codereview.chromium.org/890103002/) Reason for revert: This CL broke the gn android build. To reproduce locally on a chromium checkout src: > gn gen --args='os="android" cpu_arch="arm" use_goma=true' out_android_gn/Debug > ninja -C out_android_gn/Debug eventually fails with: [6011/25521] CXX obj/third_party/libaddressinput/chromium/libaddressinput.chrome_address_validator.o <snip> ../../third_party/libaddressinput/chromium/chrome_address_validator.cc:156:68: error: call of overloaded 'pow(int, int)' is ambiguous GetBaseRetryPeriod() * pow(2, attempts_number_[region_code]++)); Original issue's description: > [android] Remove libaddressinput Java widget. > > Android uses a custom UI with the cross-platform strings for address > input. > > BUG=454120 > > Committed: https://crrev.com/e7e8b5f5a53c3577b84413bd165731ca66d6a837 > Cr-Commit-Position: refs/heads/master@{#314217} TBR=estade@chromium.org,cpu@chromium.org,rouslan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=454120 Committed: https://crrev.com/434520c8a2751b6b24ee3d891789f88e3a62cbba Cr-Commit-Position: refs/heads/master@{#314325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -67 lines) Patch
A chrome/app/address_input_strings_android.grd View 1 chunk +66 lines, -0 lines 0 comments Download
M third_party/libaddressinput/BUILD.gn View 1 chunk +140 lines, -67 lines 0 comments Download
M third_party/libaddressinput/libaddressinput.gyp View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
perezju
Created Revert of [android] Remove libaddressinput Java widget.
5 years, 10 months ago (2015-02-03 13:37:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892403002/1
5 years, 10 months ago (2015-02-03 13:40:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 13:41:25 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/434520c8a2751b6b24ee3d891789f88e3a62cbba Cr-Commit-Position: refs/heads/master@{#314325}
5 years, 10 months ago (2015-02-03 13:42:33 UTC) #5
please use gerrit instead
5 years, 10 months ago (2015-02-03 16:51:12 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698