Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 892393003: Update harmony ObjectProtoToString() to 2/2/2015 spec (Closed)

Created:
5 years, 10 months ago by caitp (gmail)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update harmony ObjectProtoToString() to 2/2/2015 spec Applies to API implementation of O.p.toString - Removes special handling of non-string @@toStringTag values (use builtinTag) - Removes special handling of @@toStringTags which match [[Class]] names (remove ~ prefix) - Add tests for non-string @@toStringTag values in test-api.cc BUG=v8:3502 R=arv@chromium.org LOG=N Committed: https://crrev.com/b5c43674f998e5660f110271fe19fc953aee9dcb Cr-Commit-Position: refs/heads/master@{#26415}

Patch Set 1 #

Patch Set 2 : Remove unneeded --allow-natives-syntax #

Patch Set 3 : Add tests for non-string @@toStringTag in test-api.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -51 lines) Patch
M src/api.cc View 2 chunks +2 lines, -41 lines 0 comments Download
M test/cctest/cctest.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 1 chunk +48 lines, -9 lines 0 comments Download
M test/mjsunit/es6/object-tostring.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (1 generated)
caitp (gmail)
PTAL, api portion (I'm not sure if the description communicates this very well)
5 years, 10 months ago (2015-02-03 15:39:18 UTC) #1
caitp (gmail)
PTAL, api portion (I'm not sure if the description communicates this very well)
5 years, 10 months ago (2015-02-03 15:39:19 UTC) #2
caitp (gmail)
On 2015/02/03 15:39:19, caitp wrote: > PTAL, api portion (I'm not sure if the description ...
5 years, 10 months ago (2015-02-03 15:39:50 UTC) #3
arv (Not doing code reviews)
LGTM Didn't the cc test have a case for ???
5 years, 10 months ago (2015-02-03 16:06:38 UTC) #4
arv (Not doing code reviews)
On 2015/02/03 15:39:19, caitp wrote: > PTAL, api portion (I'm not sure if the description ...
5 years, 10 months ago (2015-02-03 16:07:14 UTC) #5
caitp (gmail)
On 2015/02/03 16:06:38, arv wrote: > LGTM > > Didn't the cc test have a ...
5 years, 10 months ago (2015-02-03 16:08:05 UTC) #6
caitp (gmail)
On 2015/02/03 16:08:05, caitp wrote: > On 2015/02/03 16:06:38, arv wrote: > > LGTM > ...
5 years, 10 months ago (2015-02-03 19:16:54 UTC) #7
arv (Not doing code reviews)
Still LGTM
5 years, 10 months ago (2015-02-03 20:38:53 UTC) #8
caitp (gmail)
On 2015/02/03 20:38:53, arv wrote: > Still LGTM Thanks, cq'in
5 years, 10 months ago (2015-02-03 20:40:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892393003/40001
5 years, 10 months ago (2015-02-03 20:41:08 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-03 21:05:14 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/b5c43674f998e5660f110271fe19fc953aee9dcb Cr-Commit-Position: refs/heads/master@{#26415}
5 years, 10 months ago (2015-02-03 21:05:39 UTC) #13
caitp (gmail)
5 years, 10 months ago (2015-02-03 21:29:04 UTC) #14
Message was sent while issue was closed.
On 2015/02/03 21:05:39, I haz the power (commit-bot) wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/b5c43674f998e5660f110271fe19fc953aee9dcb
> Cr-Commit-Position: refs/heads/master@{#26415}

there's a problem in debug builds... I'll work on a fix but does this need to be
reverted?

Powered by Google App Engine
This is Rietveld 408576698