emit premonomorphic ics for loads/stores in optimized code

emit premonomorphic ics for loads/stores in optimized code

R=verwaest@chromium.org

BUG=

Committed: https://crrev.com/7361dce458d1a3eecc8e3e69bf300b6508e8caad
Cr-Commit-Position: refs/heads/master@{#26796}

[dcarney, 2015-02-04 14:26:51]

dcarney@chromium.org changed reviewers:
+ verwaest@chromium.org

[dcarney, 2015-02-04 14:26:58]

ptal

[dcarney, 2015-02-05 15:42:41]

okay, loads and stores are wired up, will do keyed loads and stores in a
followup cl

[dcarney, 2015-02-09 09:07:43]

On 2015/02/05 15:42:41, dcarney wrote:
> okay, loads and stores are wired up, will do keyed loads and stores in a
> followup cl

ptal - failing test is fixed in https://codereview.chromium.org/904423002/

[Toon Verwaest, 2015-02-09 12:31:52]

... and go ahead and do the platform ports.

https://codereview.chromium.org/892383003/diff/100001/src/code-factory.cc
File src/code-factory.cc (right):

https://codereview.chromium.org/892383003/diff/100001/src/code-factory.cc#new...
src/code-factory.cc:25: bool initialize_megamorphic) {
What about using an enum (e.g. the state enum) rather than a bool?

[dcarney, 2015-02-09 13:14:54]

On 2015/02/09 12:31:52, Toon Verwaest wrote:
> ... and go ahead and do the platform ports.
> 
> https://codereview.chromium.org/892383003/diff/100001/src/code-factory.cc
> File src/code-factory.cc (right):
> 
>
https://codereview.chromium.org/892383003/diff/100001/src/code-factory.cc#new...
> src/code-factory.cc:25: bool initialize_megamorphic) {
> What about using an enum (e.g. the state enum) rather than a bool?

okay, all done

[Toon Verwaest, 2015-02-09 14:27:59]

I'd initialize to PREMONOMORPHIC for crankshaft ICs since cycling through it
seems like unnecessary overhead.
Otherwise, lgtm

https://codereview.chromium.org/892383003/diff/160001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/892383003/diff/160001/src/hydrogen.cc#newcode...
src/hydrogen.cc:6598: function_language_mode(), UNINITIALIZED);
PREMONOMORPHIC

https://codereview.chromium.org/892383003/diff/160001/src/mips64/lithium-code...
File src/mips64/lithium-codegen-mips64.cc (right):

https://codereview.chromium.org/892383003/diff/160001/src/mips64/lithium-code...
src/mips64/lithium-codegen-mips64.cc:2914:
CodeFactory::LoadICInOptimizedCode(isolate(), mode, UNINITIALIZED).code();
PREMONOMORPHIC

[dcarney, 2015-02-09 16:21:22]

New patchsets have been uploaded after l-g-t-m from verwaest@chromium.org

[dcarney, 2015-02-09 16:22:11]

The CQ bit was checked by dcarney@chromium.org

[commit-bot: I haz the power, 2015-02-09 16:22:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892383003/200001

[commit-bot: I haz the power, 2015-02-09 16:39:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-09 16:39:24]

Try jobs failed on following builders:
  v8_linux64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2800)

[dcarney, 2015-02-11 10:54:54]

The CQ bit was checked by dcarney@chromium.org

[commit-bot: I haz the power, 2015-02-11 10:55:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892383003/240001

[commit-bot: I haz the power, 2015-02-11 11:10:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-11 11:10:26]

Try jobs failed on following builders:
  v8_linux64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2864)

[dcarney, 2015-02-23 12:10:41]

The CQ bit was checked by dcarney@chromium.org

[commit-bot: I haz the power, 2015-02-23 12:11:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892383003/260001

[commit-bot: I haz the power, 2015-02-23 12:11:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892383003/260001

[commit-bot: I haz the power, 2015-02-23 12:34:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 12:34:10]

Failed to apply the patch.

[commit-bot: I haz the power, 2015-02-23 12:34:13]

Committed patchset #14 (id:260001)

[commit-bot: I haz the power, 2015-02-23 12:34:26]

Patchset 14 (id:??) landed as
https://crrev.com/7361dce458d1a3eecc8e3e69bf300b6508e8caad
Cr-Commit-Position: refs/heads/master@{#26796}