Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 892383002: RELAND: [Cast] Software encoder support for varying video frame sizes. (Closed)

Created:
5 years, 10 months ago by miu
Modified:
5 years, 10 months ago
Reviewers:
hubbe
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RELAND: [Cast] Software encoder support for varying video frame sizes. Adds support for automatic on-line reconfiguration of the VP8 software encoder whenever the video frame size changes. libvpx supports shrinking frame sizes without tearing down the encoder, but growing frames sizes still requires a full tear-down and re-creation. Most of this change involves adding extensive unit testing to confirm media/cast is now capable of handling variable frames sizes end-to-end. In addition, the cast_sender_app and cast_receiver_app diagnostic tools have been updated. An upcoming change will eliminate the width and height properties from media::cast::VideoSenderConfig, which are both being ignored now. BUG=451277 TBR=hubbe@chromium.org Committed: https://crrev.com/9a739084bdf85aba9716205e2185ffb0a278d187 Cr-Commit-Position: refs/heads/master@{#314281}

Patch Set 1 : PS3 from issue 877393003 #

Patch Set 2 : Fix for 'access to uninitialized memory' error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+576 lines, -352 lines) Patch
M media/cast/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/cast.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/receiver/video_decoder_unittest.cc View 6 chunks +50 lines, -13 lines 0 comments Download
M media/cast/sender/external_video_encoder.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/sender/external_video_encoder.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/cast/sender/fake_software_video_encoder.h View 2 chunks +2 lines, -0 lines 0 comments Download
M media/cast/sender/fake_software_video_encoder.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M media/cast/sender/h264_vt_encoder.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/sender/h264_vt_encoder.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/cast/sender/video_encoder.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/cast/sender/video_encoder_impl.h View 1 chunk +3 lines, -1 line 0 comments Download
M media/cast/sender/video_encoder_impl.cc View 3 chunks +20 lines, -1 line 0 comments Download
M media/cast/sender/video_encoder_impl_unittest.cc View 1 chunk +239 lines, -152 lines 0 comments Download
M media/cast/sender/video_sender.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M media/cast/sender/vp8_encoder.h View 3 chunks +13 lines, -5 lines 0 comments Download
M media/cast/sender/vp8_encoder.cc View 1 9 chunks +79 lines, -39 lines 0 comments Download
M media/cast/test/fake_media_source.h View 3 chunks +9 lines, -0 lines 0 comments Download
M media/cast/test/fake_media_source.cc View 9 chunks +54 lines, -38 lines 0 comments Download
M media/cast/test/linux_output_window.cc View 3 chunks +25 lines, -14 lines 0 comments Download
M media/cast/test/sender.cc View 7 chunks +37 lines, -70 lines 0 comments Download
M media/cast/test/simulator.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M media/cast/test/utility/video_utility.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/test/utility/video_utility.cc View 2 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
miu
hubbe: PTAL (a small oversight caused MSAN failures for the 3-buffer mode tests).
5 years, 10 months ago (2015-02-03 04:39:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892383002/20001
5 years, 10 months ago (2015-02-03 04:40:54 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 07:05:47 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 07:06:35 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9a739084bdf85aba9716205e2185ffb0a278d187
Cr-Commit-Position: refs/heads/master@{#314281}

Powered by Google App Engine
This is Rietveld 408576698