Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 892363002: Actually added pretest support (Closed)

Created:
5 years, 10 months ago by pgervais
Modified:
5 years, 10 months ago
Reviewers:
agable, iannucci
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/testing/expect_tests@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Yet another small fix #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M expect_tests/pipeline.py View 1 1 chunk +4 lines, -0 lines 2 comments Download
M scripts/expect_tests View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
pgervais
Committed patchset #2 (id:20001) manually as b6c4c94d63377cbd38b184af9794699e759339a8 (presubmit successful).
5 years, 10 months ago (2015-02-03 02:13:19 UTC) #1
agable
https://codereview.chromium.org/892363002/diff/20001/expect_tests/pipeline.py File expect_tests/pipeline.py (right): https://codereview.chromium.org/892363002/diff/20001/expect_tests/pipeline.py#newcode402 expect_tests/pipeline.py:402: pretest_filename = os.path.join(processing_context.cwd, '.expect_tests.py') In the documentation you committed ...
5 years, 10 months ago (2015-02-03 04:23:49 UTC) #3
agable
https://codereview.chromium.org/892363002/diff/20001/expect_tests/pipeline.py File expect_tests/pipeline.py (right): https://codereview.chromium.org/892363002/diff/20001/expect_tests/pipeline.py#newcode402 expect_tests/pipeline.py:402: pretest_filename = os.path.join(processing_context.cwd, '.expect_tests.py') On 2015/02/03 04:23:48, agable wrote: ...
5 years, 10 months ago (2015-02-03 04:27:59 UTC) #4
agable
On 2015/02/03 04:27:59, agable wrote: > https://codereview.chromium.org/892363002/diff/20001/expect_tests/pipeline.py > File expect_tests/pipeline.py (right): > > https://codereview.chromium.org/892363002/diff/20001/expect_tests/pipeline.py#newcode402 > ...
5 years, 10 months ago (2015-02-03 04:31:00 UTC) #5
agable
5 years, 10 months ago (2015-02-03 04:32:10 UTC) #6
Message was sent while issue was closed.
Final message I think: When the .expect_tests.py file is execfiled, it's
__file__ attribute is
ENV/local/lib/python2.7/site-packages/expect_tests/pipeline.pyc. So locating the
appengine sdk directory that should be added to PYTHONPATH is harder.

Powered by Google App Engine
This is Rietveld 408576698