[Slimming Paint] Add a drawing recorder for DetailsMarkerPainter::paint, and add fast/html

[Slimming Paint] Add a drawing recorder for DetailsMarkerPainter::paint, and add fast/html

BUG=446648
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189520

[chrishtr, 2015-02-03 01:12:54]

chrishtr@chromium.org changed reviewers:
+ jbroman@chromium.org, schenney@chromium.org, trchen@chromium.org

[jbroman, 2015-02-03 02:15:04]

https://codereview.chromium.org/892343002/diff/40001/Source/core/paint/Detail...
File Source/core/paint/DetailsMarkerPainter.cpp (right):

https://codereview.chromium.org/892343002/diff/40001/Source/core/paint/Detail...
Source/core/paint/DetailsMarkerPainter.cpp:31: RenderDrawingRecorder
RenderDrawingRecorder(paintInfo.context, m_renderDetailsMarker, paintInfo.phase,
overflowRect);
Should we be checking canUseCachedDrawing() here?

[chrishtr, 2015-02-03 20:27:18]

https://codereview.chromium.org/892343002/diff/40001/Source/core/paint/Detail...
File Source/core/paint/DetailsMarkerPainter.cpp (right):

https://codereview.chromium.org/892343002/diff/40001/Source/core/paint/Detail...
Source/core/paint/DetailsMarkerPainter.cpp:31: RenderDrawingRecorder
RenderDrawingRecorder(paintInfo.context, m_renderDetailsMarker, paintInfo.phase,
overflowRect);
On 2015/02/03 at 02:15:04, jbroman wrote:
> Should we be checking canUseCachedDrawing() here?

Done.

[jbroman, 2015-02-03 20:35:00]

lgtm

[chrishtr, 2015-02-03 20:37:04]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-02-03 20:38:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892343002/50001

[commit-bot: I haz the power, 2015-02-03 23:03:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-03 23:03:15]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/41090)

[chrishtr, 2015-02-03 23:08:16]

New patchsets have been uploaded after l-g-t-m from jbroman@chromium.org

[chrishtr, 2015-02-03 23:10:50]

I added some expectations of flaky marquee tests that are also flaky outside of
slimming paint.

[chrishtr, 2015-02-03 23:10:53]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-02-03 23:11:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892343002/90001

[commit-bot: I haz the power, 2015-02-04 00:58:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-04 00:58:43]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/49125)

[Jin Yang, 2015-02-04 02:40:28]

On 2015/02/03 01:12:55, chrishtr wrote:

Hi Chris,

I was enabling the fast/text, and your patch for DetailsMarkerPainter just also
fixed the failure for case text/text-appearance-datalist.html. See
https://codereview.chromium.org/895613002/
It will introduce the failure of text/text-appearance-basic.html, this failure
is caused by pixel difference in round corner of the rectangle border for input
in the case "style="border-radius: 6px", do you have any idea of the root cause
for this difference?

Thanks,
Jin

[chrishtr, 2015-02-04 05:21:18]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-02-04 05:22:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892343002/90001

[chrishtr, 2015-02-04 05:23:50]

On 2015/02/04 at 02:40:28, jin.a.yang wrote:
> On 2015/02/03 01:12:55, chrishtr wrote:
> 
> Hi Chris,
> 
> I was enabling the fast/text, and your patch for DetailsMarkerPainter just
also fixed the failure for case text/text-appearance-datalist.html. See
https://codereview.chromium.org/895613002/
> It will introduce the failure of text/text-appearance-basic.html, this failure
is caused by pixel difference in round corner of the rectangle border for input
in the case "style="border-radius: 6px", do you have any idea of the root cause
for this difference?
> 
> Thanks,
> Jin

Try undoing the slimming paint-specific code in BoxDecorationData, I suspect
that will fix the test. If it does just ignore it, since it's a known issue we
need to fix in another way (yet to be fully designed).

[commit-bot: I haz the power, 2015-02-04 07:41:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-04 07:41:25]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/41228)

[chrishtr, 2015-02-04 17:55:17]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-02-04 17:56:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892343002/90001

[commit-bot: I haz the power, 2015-02-04 18:54:32]

Committed patchset #6 (id:90001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189520