Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 892323002: Add workaround to ignore egl sync errors on qc (Closed)

Created:
5 years, 10 months ago by boliu
Modified:
5 years, 10 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org, ozone-reviews_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add workaround to ignore EGL sync errors on qc On android versions before 5.0, EGL sync objects are incorrectly destroyed when the associated EGL context is destroyed. The EGL sync objects error handling is tight to prevent driver regressions from known issues. This combined with this triggers DCHECk failures and crashes. So add another workaround to ignore errors from EGL sync object calls. BUG=453857 Committed: https://crrev.com/0599e81b61d2ab266a68dcce9d2b3c27e275f879 Cr-Commit-Position: refs/heads/master@{#314678}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase and bump version #

Patch Set 3 : OS_MACOSX #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -4 lines) Patch
M gpu/command_buffer/service/feature_info.cc View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 chunks +17 lines, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_fence_egl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_fence_egl.cc View 3 chunks +17 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
boliu
ptal this depends on https://codereview.chromium.org/898543002/
5 years, 10 months ago (2015-02-02 22:27:44 UTC) #2
no sievers
lgtm https://codereview.chromium.org/892323002/diff/1/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/892323002/diff/1/gpu/config/gpu_driver_bug_list_json.cc#newcode22 gpu/config/gpu_driver_bug_list_json.cc:22: "version": "7.14", bump version
5 years, 10 months ago (2015-02-04 20:11:21 UTC) #3
boliu
https://codereview.chromium.org/892323002/diff/1/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/892323002/diff/1/gpu/config/gpu_driver_bug_list_json.cc#newcode22 gpu/config/gpu_driver_bug_list_json.cc:22: "version": "7.14", On 2015/02/04 20:11:21, sievers wrote: > bump ...
5 years, 10 months ago (2015-02-04 21:30:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892323002/20001
5 years, 10 months ago (2015-02-04 21:31:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/30683)
5 years, 10 months ago (2015-02-04 22:20:35 UTC) #9
boliu
Ahh, EGL is !OS_MACOSX..
5 years, 10 months ago (2015-02-04 22:23:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892323002/40001
5 years, 10 months ago (2015-02-04 22:29:23 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-04 23:42:00 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 23:43:31 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0599e81b61d2ab266a68dcce9d2b3c27e275f879
Cr-Commit-Position: refs/heads/master@{#314678}

Powered by Google App Engine
This is Rietveld 408576698