Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 892273002: [Android] Add --gtest-filter-file option to the test runner. (Closed)

Created:
5 years, 10 months ago by jbudorick
Modified:
5 years, 10 months ago
Reviewers:
klundberg
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add --gtest-filter-file option to the test runner. This is proving useful for test filters involving >1 test, which I'm using heavily as I work on the net test server. BUG=428729 Committed: https://crrev.com/442a693ff2fffc12ea8acfbe04d3dbcc4674508f Cr-Commit-Position: refs/heads/master@{#314254}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M build/android/pylib/gtest/gtest_test_instance.py View 2 chunks +8 lines, -1 line 0 comments Download
M build/android/test_runner.py View 1 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jbudorick
5 years, 10 months ago (2015-02-02 18:55:44 UTC) #2
klundberg
LGTM https://codereview.chromium.org/892273002/diff/1/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/892273002/diff/1/build/android/test_runner.py#newcode220 build/android/test_runner.py:220: help='Path to file that contains gtest-style ' nit: ...
5 years, 10 months ago (2015-02-02 20:05:56 UTC) #3
jbudorick
https://codereview.chromium.org/892273002/diff/1/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/892273002/diff/1/build/android/test_runner.py#newcode220 build/android/test_runner.py:220: help='Path to file that contains gtest-style ' On 2015/02/02 ...
5 years, 10 months ago (2015-02-02 21:36:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892273002/20001
5 years, 10 months ago (2015-02-02 21:37:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 03:01:46 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 03:02:52 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/442a693ff2fffc12ea8acfbe04d3dbcc4674508f
Cr-Commit-Position: refs/heads/master@{#314254}

Powered by Google App Engine
This is Rietveld 408576698