Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 892223002: tools: fix postmortem generator (Closed)

Created:
5 years, 10 months ago by fedor.indutny
Modified:
5 years, 10 months ago
Reviewers:
danno, indutny
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

tools: fix postmortem generator BUG= R=danno Committed: https://crrev.com/a0d0c4333d2a067373441cc25dd7208c6f3e6230 Cr-Commit-Position: refs/heads/master@{#26389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M src/globals.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gen-postmortem-metadata.py View 4 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
indutny
See https://codereview.chromium.org/894003003/ for details.
5 years, 10 months ago (2015-02-02 16:43:30 UTC) #2
danno
lgtm
5 years, 10 months ago (2015-02-02 20:51:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892223002/1
5 years, 10 months ago (2015-02-02 20:51:43 UTC) #5
indutny
Is it possible to do a backport of this to 4.1?
5 years, 10 months ago (2015-02-02 20:54:20 UTC) #6
danno
Yes, but we need to let it cook in Canary for a few days
5 years, 10 months ago (2015-02-02 21:01:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 21:21:38 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a0d0c4333d2a067373441cc25dd7208c6f3e6230 Cr-Commit-Position: refs/heads/master@{#26389}
5 years, 10 months ago (2015-02-02 21:22:04 UTC) #9
indutny
5 years, 10 months ago (2015-02-02 22:18:27 UTC) #10
Message was sent while issue was closed.
Sounds perfect, thank you!

Powered by Google App Engine
This is Rietveld 408576698