Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 892213004: Mechanical rename of base::debug -> base::trace_event for /content (Closed)

Created:
5 years, 10 months ago by ssid
Modified:
5 years, 10 months ago
CC:
jam, nduca
Base URL:
https://chromium.googlesource.com/chromium/src.git@move_trace_part3_1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mechanical rename of base::debug -> base::trace_event for /content This is the last stage of the trace_event directory restructuring. This is part of a set of 3 CLs which is moving tracing clients to use the new base::trace_event namespace. See crrev.com/837303004 and the related bug for motivations. BUG=451032 TBR=jam@chromium.org NOTRY=true Committed: https://crrev.com/b2e3ececdfdc5ce1037d1bb648a7ff0f1d38f508 Cr-Commit-Position: refs/heads/master@{#315310}

Patch Set 1 #

Patch Set 2 : Removed forward declarations in /content #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -201 lines) Patch
M content/app/android/library_loader_hooks.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M content/app/content_main_runner.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/android/tracing_controller_android.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M content/browser/browser_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.h View 1 2 chunks +3 lines, -9 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/browser_shutdown_profile_dumper.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/devtools/protocol/tracing_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/devtools/protocol/tracing_handler.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M content/browser/media/webrtc_getusermedia_browsertest.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M content/browser/tracing/trace_message_filter.h View 2 chunks +7 lines, -5 lines 0 comments Download
M content/browser/tracing/trace_message_filter.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M content/browser/tracing/tracing_controller_browsertest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.h View 3 chunks +18 lines, -16 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 6 chunks +9 lines, -8 lines 0 comments Download
M content/browser/tracing/tracing_ui.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 2 3 6 chunks +7 lines, -6 lines 0 comments Download
M content/child/child_thread_impl.h View 1 2 2 chunks +1 line, -7 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M content/common/gpu/client/gl_helper_unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/plugin/plugin_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/ppapi_plugin/ppapi_broker_main.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/ppapi_plugin/ppapi_plugin_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/tracing_controller.h View 3 chunks +6 lines, -6 lines 0 comments Download
M content/public/test/browser_test_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/devtools/devtools_agent.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M content/renderer/devtools/v8_sampling_profiler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/devtools/v8_sampling_profiler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/devtools/v8_sampling_profiler_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/scheduler/renderer_scheduler_impl.h View 1 2 3 2 chunks +1 line, -7 lines 0 comments Download
M content/renderer/scheduler/renderer_scheduler_impl.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/scheduler/renderer_task_queue_selector.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/scheduler/renderer_task_queue_selector.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/scheduler/task_queue_manager.h View 1 2 2 chunks +1 line, -8 lines 0 comments Download
M content/renderer/scheduler/task_queue_manager.cc View 1 2 3 6 chunks +9 lines, -9 lines 0 comments Download
M content/renderer/scheduler/task_queue_manager_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/scheduler/task_queue_selector.h View 1 2 chunks +1 line, -7 lines 0 comments Download
M content/zygote/zygote_linux.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
ssid
This is for renaming namespace usages in /content folder
5 years, 10 months ago (2015-02-03 15:49:16 UTC) #2
Primiano Tucci (use gerrit)
The changes look good but I think that you forgot to revert the forward declarations ...
5 years, 10 months ago (2015-02-03 19:07:05 UTC) #3
ssid
On 2015/02/03 19:07:05, Primiano Tucci wrote: > The changes look good but I think that ...
5 years, 10 months ago (2015-02-03 21:13:13 UTC) #4
Primiano Tucci (use gerrit)
Thanks for the massive work. PS4 (#60001) LGTM. TBR-ing jam@ for /content changes. Reason for ...
5 years, 10 months ago (2015-02-09 11:34:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892213004/60001
5 years, 10 months ago (2015-02-09 11:35:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892213004/60001
5 years, 10 months ago (2015-02-09 11:41:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ng on ...
5 years, 10 months ago (2015-02-09 13:10:04 UTC) #12
Primiano Tucci (use gerrit)
Adding NOTRY. Apparently the ios bot on the CQ are in a very sorry state. ...
5 years, 10 months ago (2015-02-09 16:00:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892213004/60001
5 years, 10 months ago (2015-02-09 16:00:59 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-09 16:02:27 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 16:03:28 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b2e3ececdfdc5ce1037d1bb648a7ff0f1d38f508
Cr-Commit-Position: refs/heads/master@{#315310}

Powered by Google App Engine
This is Rietveld 408576698