Make HttpServerProperties::GetSupportsQuic not host-specific.

Make HttpServerProperties::GetSupportsQuic not host-specific.

Committed: https://crrev.com/a5a10a846c2cab558a556af0e7ec0cd1028ef737
Cr-Commit-Position: refs/heads/master@{#314671}

[Ryan Hamilton, 2015-02-02 23:56:20]

rch@chromium.org changed reviewers:
+ rtenneti@chromium.org

[Ryan Hamilton, 2015-02-02 23:56:21]

Raman, what do you think of this change?

[ramant (doing other things), 2015-02-03 18:09:38]

Many many thanks for making this change.

LGTM.

https://codereview.chromium.org/892203004/diff/1/net/http/http_server_propert...
File net/http/http_server_properties_manager.cc (right):

https://codereview.chromium.org/892203004/diff/1/net/http/http_server_propert...
net/http/http_server_properties_manager.cc:755: */
nit: could lines 747-755 be deleted.

https://codereview.chromium.org/892203004/diff/1/net/quic/quic_stream_factory.cc
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/892203004/diff/1/net/quic/quic_stream_factory...
net/quic/quic_stream_factory.cc:67: const uint16 kDummyPort = 0;
nit: lines 65-67 could be deleted.

https://codereview.chromium.org/892203004/diff/1/net/quic/quic_stream_factory...
net/quic/quic_stream_factory.cc:623: HostPortPair host_port_pair(kDummyHostname,
kDummyPort);
nit: line 623 could be deleted.

[Ryan Hamilton, 2015-02-03 22:50:45]

Thanks!

https://codereview.chromium.org/892203004/diff/1/net/http/http_server_propert...
File net/http/http_server_properties_manager.cc (right):

https://codereview.chromium.org/892203004/diff/1/net/http/http_server_propert...
net/http/http_server_properties_manager.cc:755: */
On 2015/02/03 18:09:37, ramant wrote:
> nit: could lines 747-755 be deleted.

Done.

https://codereview.chromium.org/892203004/diff/1/net/quic/quic_stream_factory.cc
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/892203004/diff/1/net/quic/quic_stream_factory...
net/quic/quic_stream_factory.cc:67: const uint16 kDummyPort = 0;
On 2015/02/03 18:09:37, ramant wrote:
> nit: lines 65-67 could be deleted.

Done.

https://codereview.chromium.org/892203004/diff/1/net/quic/quic_stream_factory...
net/quic/quic_stream_factory.cc:623: HostPortPair host_port_pair(kDummyHostname,
kDummyPort);
On 2015/02/03 18:09:37, ramant wrote:
> nit: line 623 could be deleted.

*facepalm* Done.

[Ryan Hamilton, 2015-02-03 22:54:09]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2015-02-03 22:55:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892203004/20001

[commit-bot: I haz the power, 2015-02-03 23:45:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-03 23:45:25]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ryan Hamilton, 2015-02-04 19:49:57]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2015-02-04 19:51:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892203004/20001

[commit-bot: I haz the power, 2015-02-04 19:58:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-04 19:58:09]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ryan Hamilton, 2015-02-04 21:43:57]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2015-02-04 21:44:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892203004/40001

[commit-bot: I haz the power, 2015-02-04 23:05:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-04 23:06:24]

Patchset 3 (id:??) landed as
https://crrev.com/a5a10a846c2cab558a556af0e7ec0cd1028ef737
Cr-Commit-Position: refs/heads/master@{#314671}