Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 892173002: Megamorphic KeyedLoadIC needs special handling for vector ics. (Closed)

Created:
5 years, 10 months ago by mvstanton
Modified:
5 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Megamorphic KeyedLoadIC needs special handling for vector ics. When --vector-ics is true, we still tail-call to the hand-written megamorphic KeyedLoadIC (formerly "generic"). Now that this code uses the megamorphic cache, it needs to deal properly with the vector and slot registers. Achieve this with a sentinel vectors/slot combo. R=dcarney@chromium.org BUG= Committed: https://crrev.com/16843e239d95f5e8eaaa06d2a0a6e371298fe11f Cr-Commit-Position: refs/heads/master@{#26381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -10 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 1 chunk +16 lines, -1 line 0 comments Download
M src/ic/arm64/ic-arm64.cc View 2 chunks +16 lines, -2 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 1 chunk +19 lines, -2 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 1 chunk +15 lines, -1 line 0 comments Download
M src/ic/x64/ic-x64.cc View 1 chunk +18 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mvstanton
Hi Dan, here is the change to restore --vector-ics functionality. Thanks for the look! --Michael
5 years, 10 months ago (2015-02-02 13:09:27 UTC) #1
dcarney
lgtm, assuming no registers are trashed before getting to that point
5 years, 10 months ago (2015-02-02 13:12:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892173002/1
5 years, 10 months ago (2015-02-02 13:42:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 13:55:07 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 13:55:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16843e239d95f5e8eaaa06d2a0a6e371298fe11f
Cr-Commit-Position: refs/heads/master@{#26381}

Powered by Google App Engine
This is Rietveld 408576698