Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1846)

Unified Diff: net/http/disk_cache_based_quic_server_info.cc

Issue 892083006: QUIC - Browser shutdown crash fix. Accessing disk_cache's backend after (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/disk_cache_based_quic_server_info_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/disk_cache_based_quic_server_info.cc
diff --git a/net/http/disk_cache_based_quic_server_info.cc b/net/http/disk_cache_based_quic_server_info.cc
index 6a5ee175d5187f8773a75d2c88f8dc26415e26f5..303e13d63d2bf51044a97edf16591b3ef2fcd42b 100644
--- a/net/http/disk_cache_based_quic_server_info.cc
+++ b/net/http/disk_cache_based_quic_server_info.cc
@@ -104,7 +104,10 @@ int DiskCacheBasedQuicServerInfo::WaitForDataReady(
void DiskCacheBasedQuicServerInfo::CancelWaitForDataReadyCallback() {
DCHECK(CalledOnValidThread());
- RecordQuicServerInfoStatus(QUIC_SERVER_INFO_WAIT_FOR_DATA_READY_CANCEL);
+ // TODO(rtenneti): crbug.com/456524. Implement a better fix. During shutdown,
+ // HttpCache could be deleted and leads to crash because backend_ is deleted.
+ // Temporary weekend fix is to return without collecting data in histograms.
+ // RecordQuicServerInfoStatus(QUIC_SERVER_INFO_WAIT_FOR_DATA_READY_CANCEL);
if (!wait_for_ready_callback_.is_null()) {
RecordLastFailure();
wait_for_ready_callback_.Reset();
« no previous file with comments | « no previous file | net/http/disk_cache_based_quic_server_info_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698