Files.app: Use new metadata models in DirectoryModel.

Files.app: Use new metadata models in DirectoryModel.

The CL adds new metadata model to DirectoryModel, and let DirectoryModel call the new metadata model's method to notify change of Entry.

BUG=410766
TEST=None

Committed: https://crrev.com/c597cef34788d703e14fe1b08c8335314a966294
Cr-Commit-Position: refs/heads/master@{#314988}

[hirono, 2015-02-06 03:58:44]

hirono@chromium.org changed reviewers:
+ mtomasz@chromium.org, yawano@chromium.org

[hirono, 2015-02-06 03:58:45]

@mtomazs, @yawano

At the begging of week, I added the series of new metadata model patches with
@yawano's review because @mtomasz OOO at the beginning of this week. I'm
planning to send the upcoming patches to either of you, for balancing review
load.

The new models I added consists of these classes:

* FileSystemMetadataModel (integrator of file system and external metadata
providers)
* XXXProvider (new providers)
* MetadataCacheSet (cache class for entries)
* MetadataCacheItem (cache class for an entry)
* MetadataCacheItemProperty (cache class for a property of an entry)

And this is the first patch to start to use the new classes in Files.app.

Thanks!

[hirono, 2015-02-06 03:58:58]

hirono@chromium.org changed reviewers:
- yawano@chromium.org

[mtomasz, 2015-02-06 04:08:34]

quick scan, lgtm with some nits

https://codereview.chromium.org/892083004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/directory_model.js (right):

https://codereview.chromium.org/892083004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/directory_model.js:19: * @param
{!FileSystemMetadataModel} fileSystemMetadataModel The metadata cache
nit: The variable name is very long. Maybe we can shorten it to
fileSystemMetadata? But as you prefer.

https://codereview.chromium.org/892083004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/file_manager.js (right):

https://codereview.chromium.org/892083004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/file_manager.js:699:
assert(this.volumeManager_));
nit: Is this assert as an argument correct?

https://codereview.chromium.org/892083004/diff/1/ui/file_manager/file_manager...
File
ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_model.js
(right):

https://codereview.chromium.org/892083004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_model.js:95:
* Clears old metadata for newly created entries.
nit: @param missing

[hirono, 2015-02-06 06:17:02]

New patchsets have been uploaded after l-g-t-m from mtomasz@chromium.org

[hirono, 2015-02-06 06:18:26]

The CQ bit was checked by hirono@chromium.org

[hirono, 2015-02-06 06:18:34]

Thanks!

https://codereview.chromium.org/892083004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/directory_model.js (right):

https://codereview.chromium.org/892083004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/directory_model.js:19: * @param
{!FileSystemMetadataModel} fileSystemMetadataModel The metadata cache
On 2015/02/06 04:08:33, mtomasz wrote:
> nit: The variable name is very long. Maybe we can shorten it to
> fileSystemMetadata? But as you prefer.

Done.

https://codereview.chromium.org/892083004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/file_manager.js (right):

https://codereview.chromium.org/892083004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/file_manager.js:699:
assert(this.volumeManager_));
On 2015/02/06 04:08:33, mtomasz wrote:
> nit: Is this assert as an argument correct?

assert returns non-nullable type of the argument, so it worked.
But I fixed it for consistency.

https://codereview.chromium.org/892083004/diff/1/ui/file_manager/file_manager...
File
ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_model.js
(right):

https://codereview.chromium.org/892083004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_model.js:95:
* Clears old metadata for newly created entries.
On 2015/02/06 04:08:33, mtomasz wrote:
> nit: @param missing

Done.

[commit-bot: I haz the power, 2015-02-06 06:19:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892083004/20001

[mtomasz, 2015-02-06 06:19:51]

lgtm

https://codereview.chromium.org/892083004/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/directory_model.js (right):

https://codereview.chromium.org/892083004/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/directory_model.js:833: 
nit: Is this \n intentional?

[hirono, 2015-02-06 06:31:45]

https://codereview.chromium.org/892083004/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/directory_model.js (right):

https://codereview.chromium.org/892083004/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/directory_model.js:833: 
On 2015/02/06 06:19:51, mtomasz wrote:
> nit: Is this \n intentional?

Yes, the original code also had break lines at #833 and #843.
It looks they are for separating then blocks.

[commit-bot: I haz the power, 2015-02-06 06:43:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-06 06:44:35]

Patchset 2 (id:??) landed as
https://crrev.com/c597cef34788d703e14fe1b08c8335314a966294
Cr-Commit-Position: refs/heads/master@{#314988}