Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 892073002: [deprecated][Restart] clearResource

Created:
5 years, 10 months ago by hiroshige
Modified:
5 years, 10 months ago
Reviewers:
CC:
tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Prevent DocumentThreadableLoader from calling m_client handlers after didFailAccessControlCheck() There were cases where m_client->didFinishLoading() was called after m_client->didFailAccessControlCheck() is called. This CL fixes that by clearing resource in handlePreflightFailure(), and always calling handlePreflightFailure() instead of calling didFailAccessControlCheck() directly. BUG=421627

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Comments. #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M Source/core/loader/DocumentThreadableLoader.cpp View 1 2 3 4 chunks +11 lines, -4 lines 0 comments Download
M Source/web/tests/AssociatedURLLoaderTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (2 generated)
hiroshige
Patchset #6 (id:100001) has been deleted
5 years, 10 months ago (2015-02-03 08:15:00 UTC) #1
hiroshige
5 years, 10 months ago (2015-02-03 08:15:07 UTC) #2 
Patchset #6 (id:120001) has been deleted

Powered by Google App Engine
This is Rietveld 408576698