src/IceTranslator.h - Issue 892063002: Subzero: Manage each Cfg as a std::unique_ptr<Cfg>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTranslator.h

Issue 892063002: Subzero: Manage each Cfg as a std::unique_ptr<Cfg>. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review updates Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTranslator.h

diff --git a/src/IceTranslator.h b/src/IceTranslator.h

index cd5a8d6b7cef9cc0044875ec680d174fbb59aa1a..6b35b25f97ae43167f18ed773227e2cb57c352f5 100644

--- a/src/IceTranslator.h

+++ b/src/IceTranslator.h

@@ -45,7 +45,7 @@ public:

/// Translates the constructed ICE function Fcn to machine code.

/// Takes ownership of Func.

- void translateFcn(Cfg *Func);

+ void translateFcn(std::unique_ptr<Cfg> Func);

/// Emits the constant pool.

void emitConstants();

« src/IceGlobalContext.cpp ('K') | « src/IceGlobalContext.cpp ('k') | src/IceTranslator.cpp » ('j') | src/IceTranslator.cpp » ('J')