src/IceCfg.cpp - Issue 892063002: Subzero: Manage each Cfg as a std::unique_ptr<Cfg>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceCfg.cpp

Issue 892063002: Subzero: Manage each Cfg as a std::unique_ptr<Cfg>. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Commit fix + rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceCfg.cpp

diff --git a/src/IceCfg.cpp b/src/IceCfg.cpp

index 53f9a9f76a46f7f0752c349540c246757a378fe5..b284d06f16ffe4d8730f596a88952d9fdb3bc4fe 100644

--- a/src/IceCfg.cpp

+++ b/src/IceCfg.cpp

@@ -46,11 +46,7 @@ Cfg::Cfg(GlobalContext *Ctx)

"Attempt to build cfg when IR generation disabled");

}

-Cfg::~Cfg() {

- assert(ICE_TLS_GET_FIELD(CurrentCfg) == this);

- // Reset the thread-local CurrentCfg pointer.

- ICE_TLS_SET_FIELD(CurrentCfg, nullptr);

+Cfg::~Cfg() { assert(ICE_TLS_GET_FIELD(CurrentCfg) == nullptr); }

void Cfg::setError(const IceString &Message) {

HasError = true;

« no previous file with comments | « src/IceCfg.h ('k') | src/IceConverter.cpp » ('j') | no next file with comments »